QtNetwork auto tests: port Q_FOREACH to ranged-for [1]

The loops were iterating over a temporary, so use a local const auto
variable to hold it, and use ranged-for.

Drive-by, make the for-loop variable const& instead of copying it,
for any object that has a d-pointer (QNetworkAddressEntry, QHostAddress,
QNetworkInterface).

Task-number: QTBUG-115839
Change-Id: If96c0b2a6142fe2fa2ed45ed7e2435cc1f80e005
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>

1 files changed, 8 insertions, 6 deletions

diff --git a/tests/auto/network/kernel/qnetworkinterface/tst_qnetworkinterface.cpp b/tests/auto/network/kernel/qnetworkinterface/tst_qnetworkinterface.cpp
index e0436d2d99..5fa684ca14 100644
--- a/tests/auto/network/kernel/qnetworkinterface/tst_qnetworkinterface.cpp
+++ b/tests/auto/network/kernel/qnetworkinterface/tst_qnetworkinterface.cpp
@@ -100,7 +100,8 @@ void tst_QNetworkInterface::dump()
         qDebug() << "    MTU:       " << i.maximumTransmissionUnit();
 
         int count = 0;
-        foreach (const QNetworkAddressEntry &e, i.addressEntries()) {
+        const auto entries = i.addressEntries();
+        for (const QNetworkAddressEntry &e : entries) {
             QDebug s = qDebug();
             s.nospace() <<    "    address "
                         << qSetFieldWidth(2) << count++ << qSetFieldWidth(0);
@@ -126,11 +127,11 @@ void tst_QNetworkInterface::dump()
 
 void tst_QNetworkInterface::consistencyCheck()
 {
-    QList<QNetworkInterface> ifaces = QNetworkInterface::allInterfaces();
+    const QList<QNetworkInterface> ifaces = QNetworkInterface::allInterfaces();
     QSet<QString> interfaceNames;
     QList<int> interfaceIndexes;
 
-    foreach (const QNetworkInterface &iface, ifaces) {
+    for (const QNetworkInterface &iface : ifaces) {
         QVERIFY(iface.isValid());
         QVERIFY2(!interfaceNames.contains(iface.name()),
                  "duplicate name = " + iface.name().toLocal8Bit());
@@ -251,10 +252,10 @@ void tst_QNetworkInterface::interfaceFromXXX_data()
 {
     QTest::addColumn<QNetworkInterface>("iface");
 
-    QList<QNetworkInterface> allInterfaces = QNetworkInterface::allInterfaces();
+    const QList<QNetworkInterface> allInterfaces = QNetworkInterface::allInterfaces();
     if (allInterfaces.size() == 0)
         QSKIP("No interfaces to test!");
-    foreach (QNetworkInterface iface, allInterfaces)
+    for (const QNetworkInterface &iface : allInterfaces)
         QTest::newRow(iface.name().toLocal8Bit()) << iface;
 }
 
@@ -268,7 +269,8 @@ void tst_QNetworkInterface::interfaceFromXXX()
         QCOMPARE(QNetworkInterface::interfaceNameFromIndex(idx), iface.name());
         QCOMPARE(QNetworkInterface::interfaceIndexFromName(iface.name()), idx);
     }
-    foreach (QNetworkAddressEntry entry, iface.addressEntries()) {
+    const auto entries = iface.addressEntries();
+    for (const QNetworkAddressEntry &entry : entries) {
         QVERIFY(!entry.ip().isNull());
 
         if (!entry.netmask().isNull()) {