path: root/tests/auto/network/socket/platformsocketengine
diff options
authorJason McDonald <>2011-10-06 18:56:31 +1000
committerQt by Nokia <>2011-10-07 04:30:30 +0200
commit924d810dbdcd5b5b0fa860922b2487ea9062d002 (patch)
treeb14117ac5b9a2d8d02a502adbd00b94ba5eef424 /tests/auto/network/socket/platformsocketengine
parent13251dcaea443d2f228fc797e54318191048e588 (diff)
Avoid using QSKIP in lieu of compile-time checks
QSKIP is intended to be used to skip test functions that are found at run-time to be inapplicable or unsafe. If a test function can be determined to be inapplicable at compile-time, the entire test function should be omitted instead of replacing the body of the test function with a QSKIP, which only serves to slow down test runs and to inflate test run-rates with empty, inapplicable tests. Task-number: QTQAINFRA-278 Change-Id: I95feba3edbfa092c0ef4d85bb8c6877bd6be698e Reviewed-on: Reviewed-by: Qt Sanity Bot <> Reviewed-by: Rohan McGovern <>
Diffstat (limited to 'tests/auto/network/socket/platformsocketengine')
1 files changed, 3 insertions, 6 deletions
diff --git a/tests/auto/network/socket/platformsocketengine/tst_platformsocketengine.cpp b/tests/auto/network/socket/platformsocketengine/tst_platformsocketengine.cpp
index 1b74d2ec55..f3aae4b09e 100644
--- a/tests/auto/network/socket/platformsocketengine/tst_platformsocketengine.cpp
+++ b/tests/auto/network/socket/platformsocketengine/tst_platformsocketengine.cpp
@@ -656,12 +656,8 @@ void tst_PlatformSocketEngine::receiveUrgentData()
int available;
QByteArray response;
-#if defined Q_OS_HPUX
- QSKIP("Native OOB data test doesn't work on HP-UX.", SkipAll);
-#elif defined (Q_OS_WINCE)
- QSKIP("Native OOB data test doesn't work on WinCE.", SkipAll);
+ // Native OOB data test doesn't work on HP-UX or WinCE
+#if !defined(Q_OS_HPUX) && !defined(Q_OS_WINCE)
// The server sends an urgent message
msg = 'Q';
QCOMPARE(int(::send(socketDescriptor, &msg, sizeof(msg), MSG_OOB)), 1);
@@ -686,6 +682,7 @@ void tst_PlatformSocketEngine::receiveUrgentData()
QCOMPARE(, response.size()), qint64(1));
QCOMPARE(, msg);