summaryrefslogtreecommitdiffstats
path: root/tests/auto/network/socket
diff options
context:
space:
mode:
authorLars Knoll <lars.knoll@qt.io>2020-09-10 20:39:49 +0200
committerLars Knoll <lars.knoll@qt.io>2020-09-11 00:20:47 +0200
commit6ae7a02104631a2234c475575ae15ca79bef14f9 (patch)
tree5ca2db0e3aa3c7851c6d19117147c581bebeeee3 /tests/auto/network/socket
parent459e8dfdfb8ac164383c14332b2b0919f59f8b3c (diff)
Remove most compiler warnings about missing overrides
Remove around 1000 compiler warnings about missing overrides in our auto tests. This significantly reduce the compiler warning noise in our auto tests, so that one can actually better see the real problems inbetween. Change-Id: Id0c04dba43fcaf55d8cd2b5c6697358857c31bf9 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Diffstat (limited to 'tests/auto/network/socket')
-rw-r--r--tests/auto/network/socket/qsocks5socketengine/tst_qsocks5socketengine.cpp12
-rw-r--r--tests/auto/network/socket/qtcpserver/tst_qtcpserver.cpp6
-rw-r--r--tests/auto/network/socket/qtcpsocket/stressTest/Test.h2
-rw-r--r--tests/auto/network/socket/qtcpsocket/tst_qtcpsocket.cpp8
4 files changed, 14 insertions, 14 deletions
diff --git a/tests/auto/network/socket/qsocks5socketengine/tst_qsocks5socketengine.cpp b/tests/auto/network/socket/qsocks5socketengine/tst_qsocks5socketengine.cpp
index 6414aa6c82..f0cff5da3e 100644
--- a/tests/auto/network/socket/qsocks5socketengine/tst_qsocks5socketengine.cpp
+++ b/tests/auto/network/socket/qsocks5socketengine/tst_qsocks5socketengine.cpp
@@ -73,14 +73,14 @@ private slots:
void incomplete();
protected slots:
- void proxyAuthenticationRequired(const QNetworkProxy &proxy, QAuthenticator *auth);
+ void proxyAuthenticationRequired(const QNetworkProxy &proxy, QAuthenticator *auth) override;
private:
- void readNotification() { }
- void writeNotification() { }
- void closeNotification() { }
- void exceptionNotification() { }
- void connectionNotification() { }
+ void readNotification() override { }
+ void writeNotification() override { }
+ void closeNotification() override { }
+ void exceptionNotification() override { }
+ void connectionNotification() override { }
};
class MiniSocks5ResponseHandler : public QObject
diff --git a/tests/auto/network/socket/qtcpserver/tst_qtcpserver.cpp b/tests/auto/network/socket/qtcpserver/tst_qtcpserver.cpp
index 927dc5cf9a..1bf6777040 100644
--- a/tests/auto/network/socket/qtcpserver/tst_qtcpserver.cpp
+++ b/tests/auto/network/socket/qtcpserver/tst_qtcpserver.cpp
@@ -474,7 +474,7 @@ public:
}
protected:
- void run()
+ void run() override
{
sleep(2);
@@ -575,7 +575,7 @@ public:
bool ok;
protected:
- void incomingConnection(qintptr socketDescriptor)
+ void incomingConnection(qintptr socketDescriptor) override
{
// how a user woulddo it (qabstractsocketengine is not public)
unsigned long arg = 0;
@@ -713,7 +713,7 @@ public:
lastQuery = QNetworkProxyQuery();
}
- virtual QList<QNetworkProxy> queryProxy(const QNetworkProxyQuery &query)
+ virtual QList<QNetworkProxy> queryProxy(const QNetworkProxyQuery &query) override
{
lastQuery = query;
++callCount;
diff --git a/tests/auto/network/socket/qtcpsocket/stressTest/Test.h b/tests/auto/network/socket/qtcpsocket/stressTest/Test.h
index 7839cb2c89..3e61456f75 100644
--- a/tests/auto/network/socket/qtcpsocket/stressTest/Test.h
+++ b/tests/auto/network/socket/qtcpsocket/stressTest/Test.h
@@ -56,7 +56,7 @@ public:
My4Server(QObject *parent = 0);
protected:
- void incomingConnection(qintptr socket);
+ void incomingConnection(qintptr socket) override;
private slots:
void stopServer();
diff --git a/tests/auto/network/socket/qtcpsocket/tst_qtcpsocket.cpp b/tests/auto/network/socket/qtcpsocket/tst_qtcpsocket.cpp
index 3c4728afec..b9108932f7 100644
--- a/tests/auto/network/socket/qtcpsocket/tst_qtcpsocket.cpp
+++ b/tests/auto/network/socket/qtcpsocket/tst_qtcpsocket.cpp
@@ -1375,7 +1375,7 @@ public:
}
protected:
- void run()
+ void run() override
{
bool timedOut = false;
while (!quit) {
@@ -1865,7 +1865,7 @@ public:
}
protected:
- inline void run()
+ inline void run() override
{
#ifndef QT_NO_SSL
QFETCH_GLOBAL(bool, ssl);
@@ -2265,7 +2265,7 @@ class TestThread2 : public QThread
{
Q_OBJECT
public:
- void run()
+ void run() override
{
QFile fileWriter("fifo");
QVERIFY(fileWriter.open(QFile::WriteOnly));
@@ -2880,7 +2880,7 @@ public:
lastQuery = QNetworkProxyQuery();
}
- virtual QList<QNetworkProxy> queryProxy(const QNetworkProxyQuery &query)
+ virtual QList<QNetworkProxy> queryProxy(const QNetworkProxyQuery &query) override
{
lastQuery = query;
++callCount;