summaryrefslogtreecommitdiffstats
path: root/tests/auto/other
diff options
context:
space:
mode:
authorEdward Welbourne <edward.welbourne@qt.io>2021-09-27 11:42:24 +0200
committerEdward Welbourne <edward.welbourne@qt.io>2021-10-04 16:03:36 +0200
commit3a8c8e7cf620883af0e2b7ba6bfb1e5fced46b42 (patch)
tree69c50ead1312029b678e3532aeaed72ef34ee825 /tests/auto/other
parente0ecb0ded21082f4e00ee77411339009cb1294a4 (diff)
Remove an overly-complex assertion
It tried to sanity-check the correction being made to the time as a result of converting zone to UTC, but handling also the case where the correction avoided a gap. However, there are too many quirky cases to permit a simple condition. The latest to trip it up is a case of a zone leaving local solar mean time; a time in the gap that hits is shunted by the width of the gap, which could be any old thing, and won't show up on the data describing the zone before or after the transition. In any case, one branch of the check was doubling the zone's standard time offset, which makes no sense. As that was checking for double-DST, it would need to check standard offset plus twice the usual DST offset; but the data it's looking at probably has its DST offset set to the doubled one that needs to deal with. In general a change in DST without going via standard time will have problems here, and a change to standard time could also present problems. Stop trying to shore up the assert and just trust the offset we got. Change-Id: I4519f47e79dfb7595f4a12c259b80a338bc7033c Reviewed-by: Andreas Buhr <andreas.buhr@qt.io> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'tests/auto/other')
0 files changed, 0 insertions, 0 deletions