summaryrefslogtreecommitdiffstats
path: root/tests/auto/qtoolbutton/qtoolbutton.pro
diff options
context:
space:
mode:
authorBradley T. Hughes <bradley.hughes@nokia.com>2011-09-23 12:29:18 +0200
committerQt by Nokia <qt-info@nokia.com>2011-09-23 13:42:22 +0200
commita219b8f3822a00e9bc2ae18419fa774355bb90b3 (patch)
tree4ccdb6b3a0caa0224129707de7bc6fa29a3fd7d8 /tests/auto/qtoolbutton/qtoolbutton.pro
parentea546c05f13858ca99bb3d8342131cae39d627c2 (diff)
Fix QString and QByteArray reserve() and squeeze()
These functions should not take care not to unconditionally set the capacityReserved private member, since the d may be referencing the const shared_null or shared_empty which live in read-only memory. The squeeze() methods check for ref > 1 instead of ref != 1 to prevent detaching from the shared_null/shared_empty unnecessarily; the shared_null/shared_empty ref count is -1, meaning squeeze() will never detach from it. Change-Id: Id3f1725a6f08b3a462343640a47bbe78f08ca7e7 Rubberstamped-by: Lars Knoll Reviewed-on: http://codereview.qt-project.org/5454 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Diffstat (limited to 'tests/auto/qtoolbutton/qtoolbutton.pro')
0 files changed, 0 insertions, 0 deletions