diff options
| author | Tor Arne Vestbø <tor.arne.vestbo@qt.io> | 2021-08-01 15:17:17 +0200 |
|---|---|---|
| committer | Tor Arne Vestbø <tor.arne.vestbo@qt.io> | 2021-08-05 03:58:50 +0200 |
| commit | a71b9c937719bc3a5f4de6e91dbdbe364df38cac (patch) | |
| tree | 59bb257170db1fe118c158d44e48a35763afeac1 /tests/auto/testlib/selftests/expected_blacklisted.tap | |
| parent | c95d7741b74bc617d86297dbfa5cd7d1df98f8c3 (diff) | |
testlib: Clean up tst_blacklist
33d7f76f0e847d7e0fb00dd6056e7bba45b8b1e7 attempted to exercise more
of the blacklisting code, but in doing so didn't account for the
fact that the features it added didn't actually work.
Adding a global blacklisting of * will result in blacklisting
all tests, regardless of any inverse conditions "!*" later on,
such as for the 'pass' test. This would have been evident by
looking at the expectation files, which still showed the test
as a BPASS.
The broken feature should be fixed, but in the meantime let's
clean up the test so it doesn't misrepresent reality.
At the same time we also remove the messages() tests, which was
copied straight out of tst_silent, but doesn't serve any purpose
for the blacklist selftest.
Pick-to: 6.2
Change-Id: I20e4693300aad5e9ff5f17ad22e3dfcb5c49fd0e
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Diffstat (limited to 'tests/auto/testlib/selftests/expected_blacklisted.tap')
| -rw-r--r-- | tests/auto/testlib/selftests/expected_blacklisted.tap | 17 |
1 files changed, 2 insertions, 15 deletions
diff --git a/tests/auto/testlib/selftests/expected_blacklisted.tap b/tests/auto/testlib/selftests/expected_blacklisted.tap index 9d589a6552..fee7750a12 100644 --- a/tests/auto/testlib/selftests/expected_blacklisted.tap +++ b/tests/auto/testlib/selftests/expected_blacklisted.tap @@ -23,21 +23,8 @@ not ok 6 - xfail() # TODO This test should BXFAIL then BPASS line: 0 ... ok 7 - xpass() # TODO 'true' returned TRUE unexpectedly. (This test should BXPASS) -# This is a warning that should not appear in silent test output -# This is an internal testlib warning that should not appear in silent test output -# This is a debug message that should not appear in silent test output -# This is a critical message that should not appear in silent test output -# This is an info message that should not appear in silent test output -# This is an internal testlib info message that should not appear in silent test output -# This is a fatal error message that should still appear in silent test output -not ok 8 - messages() # TODO Received a fatal error. - --- - # Received a fatal error. - at: tst_Blacklisted::messages() (qtbase/tests/auto/testlib/selftests/blacklisted/tst_blacklisted.cpp:0) - file: qtbase/tests/auto/testlib/selftests/blacklisted/tst_blacklisted.cpp - line: 0 - ... +ok 8 - cleanupTestCase() 1..8 # tests 8 -# pass 1 +# pass 2 # fail 0 |