QtTestLib: unify handling of float and double using suitable templates

The QTest::qCompare() implementations were almost duplicates; pull the
common code out into a templated version.  Tweaked the
QTest::toString() specialization for float and double (a macro) and
fixed a bous modifier in double's format.

The doubleComparisons and floatComparisons tests in the tst_float.cpp
selftest shared a large block of tests in common, aside from the
difference of type.  Break this out into a templated static function
to save duplication.

This prepares the way for using the same templated code for qfloat16.

Change-Id: I2823fd006910c5ff88335d625d1fa05cb7753513
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

1 files changed, 63 insertions, 92 deletions

diff --git a/tests/auto/testlib/selftests/float/tst_float.cpp b/tests/auto/testlib/selftests/float/tst_float.cpp
index 49d00ac0e0..621dd1ccd9 100644
--- a/tests/auto/testlib/selftests/float/tst_float.cpp
+++ b/tests/auto/testlib/selftests/float/tst_float.cpp
@@ -46,6 +46,55 @@ private slots:
     void compareFloatTests_data() const;
 };
 
+template<typename F>
+static void nonFinite_data(F zero, F one)
+{
+    using Bounds = std::numeric_limits<F>;
+
+    // QCOMPARE special-cases non-finite values
+    if (Bounds::has_quiet_NaN) {
+        const F nan = Bounds::quiet_NaN();
+        QTest::newRow("should PASS: NaN == NaN") << nan << nan;
+        QTest::newRow("should FAIL: NaN != 0") << nan << zero;
+        QTest::newRow("should FAIL: 0 != NaN") << zero << nan;
+        QTest::newRow("should FAIL: NaN != 1") << nan << one;
+        QTest::newRow("should FAIL: 1 != NaN") << one << nan;
+    }
+
+    if (Bounds::has_infinity) {
+        const F uge = Bounds::infinity();
+        QTest::newRow("should PASS: inf == inf") << uge << uge;
+        QTest::newRow("should PASS: -inf == -inf") << -uge << -uge;
+        QTest::newRow("should FAIL: inf != -inf") << uge << -uge;
+        QTest::newRow("should FAIL: -inf != inf") << -uge << uge;
+        if (Bounds::has_quiet_NaN) {
+            const F nan = Bounds::quiet_NaN();
+            QTest::newRow("should FAIL: inf != nan") << uge << nan;
+            QTest::newRow("should FAIL: nan != inf") << nan << uge;
+            QTest::newRow("should FAIL: -inf != nan") << -uge << nan;
+            QTest::newRow("should FAIL: nan != -inf") << nan << -uge;
+        }
+        QTest::newRow("should FAIL: inf != 0") << uge << zero;
+        QTest::newRow("should FAIL: 0 != inf") << zero << uge;
+        QTest::newRow("should FAIL: -inf != 0") << -uge << zero;
+        QTest::newRow("should FAIL: 0 != -inf") << zero << -uge;
+        QTest::newRow("should FAIL: inf != 1") << uge << one;
+        QTest::newRow("should FAIL: 1 != inf") << one << uge;
+        QTest::newRow("should FAIL: -inf != 1") << -uge << one;
+        QTest::newRow("should FAIL: 1 != -inf") << one << -uge;
+
+        const F big = Bounds::max();
+        QTest::newRow("should FAIL: inf != max") << uge << big;
+        QTest::newRow("should FAIL: inf != -max") << uge << -big;
+        QTest::newRow("should FAIL: max != inf") << big << uge;
+        QTest::newRow("should FAIL: -max != inf") << -big << uge;
+        QTest::newRow("should FAIL: -inf != max") << -uge << big;
+        QTest::newRow("should FAIL: -inf != -max") << -uge << -big;
+        QTest::newRow("should FAIL: max != -inf") << big << -uge;
+        QTest::newRow("should FAIL: -max != -inf") << -big << -uge;
+    }
+}
+
 void tst_float::doubleComparisons() const
 {
     QFETCH(double, operandLeft);
@@ -58,65 +107,26 @@ void tst_float::doubleComparisons_data() const
 {
     QTest::addColumn<double>("operandLeft");
     QTest::addColumn<double>("operandRight");
+    double zero(0.), one(1.);
 
-    QTest::newRow("should PASS 1") << 0. << 0.;
-    QTest::newRow("should FAIL 1") << 1.00000 << 3.00000;
-    QTest::newRow("should FAIL 2") << 1.00000e-7 << 3.00000e-7;
+    QTest::newRow("should FAIL 1") << one << 3.;
+    QTest::newRow("should PASS 1") << zero << zero;
+    QTest::newRow("should FAIL 2") << 1.e-7 << 3.e-7;
 
     // QCOMPARE for doubles uses qFuzzyCompare(), which succeeds if the numbers
     // differ by no more than 1e-12 times the smaller value.  Thus
     // QCOMPARE(1e12-2, 1e12-1) should fail, while QCOMPARE(1e12+1, 1e12+2)
     // should pass.
 
-    QTest::newRow("should PASS 2") << 1e12 + 1. << 1e12 + 2.;
-    QTest::newRow("should FAIL 3") << 1e12 - 1. << 1e12 - 2.;
+    QTest::newRow("should PASS 2") << 1e12 + one << 1e12 + 2.;
+    QTest::newRow("should FAIL 3") << 1e12 - one << 1e12 - 2.;
     // ... but rounding makes that a bit unrelaible when scaled close to the bounds.
     QTest::newRow("should PASS 3") << 1e-310 + 1e-322 << 1e-310 + 2e-322;
     QTest::newRow("should FAIL 4") << 1e-310 - 1e-322 << 1e-310 - 3e-322;
     QTest::newRow("should PASS 4") << 1e307 + 1e295 << 1e307 + 2e295;
     QTest::newRow("should FAIL 5") << 1e307 - 1e295 << 1e307 - 3e295;
 
-    // QCOMPARE special-cases non-finite values
-    if (std::numeric_limits<double>::has_quiet_NaN) {
-        const double nan = std::numeric_limits<double>::quiet_NaN();
-        QTest::newRow("should PASS: NaN == NaN") << nan << nan;
-        QTest::newRow("should FAIL: NaN != 0") << nan << 0.;
-        QTest::newRow("should FAIL: 0 != NaN") << 0. << nan;
-        QTest::newRow("should FAIL: NaN != 1") << nan << 1.;
-        QTest::newRow("should FAIL: 1 != NaN") << 1. << nan;
-    }
-    if (std::numeric_limits<double>::has_infinity) {
-        const double uge = std::numeric_limits<double>::infinity();
-        QTest::newRow("should PASS: inf == inf") << uge << uge;
-        QTest::newRow("should PASS: -inf == -inf") << -uge << -uge;
-        QTest::newRow("should FAIL: inf != -inf") << uge << -uge;
-        QTest::newRow("should FAIL: -inf != inf") << -uge << uge;
-        if (std::numeric_limits<double>::has_quiet_NaN) {
-            const double nan = std::numeric_limits<double>::quiet_NaN();
-            QTest::newRow("should FAIL: inf != nan") << uge << nan;
-            QTest::newRow("should FAIL: nan != inf") << nan << uge;
-            QTest::newRow("should FAIL: -inf != nan") << -uge << nan;
-            QTest::newRow("should FAIL: nan != -inf") << nan << -uge;
-        }
-        QTest::newRow("should FAIL: inf != 0") << uge << 0.;
-        QTest::newRow("should FAIL: 0 != inf") << 0. << uge;
-        QTest::newRow("should FAIL: -inf != 0") << -uge << 0.;
-        QTest::newRow("should FAIL: 0 != -inf") << 0. << -uge;
-        QTest::newRow("should FAIL: inf != 1") << uge << 1.;
-        QTest::newRow("should FAIL: 1 != inf") << 1. << uge;
-        QTest::newRow("should FAIL: -inf != 1") << -uge << 1.;
-        QTest::newRow("should FAIL: 1 != -inf") << 1. << -uge;
-
-        const double big = std::numeric_limits<double>::max();
-        QTest::newRow("should FAIL: inf != max") << uge << big;
-        QTest::newRow("should FAIL: inf != -max") << uge << -big;
-        QTest::newRow("should FAIL: max != inf") << big << uge;
-        QTest::newRow("should FAIL: -max != inf") << -big << uge;
-        QTest::newRow("should FAIL: -inf != max") << -uge << big;
-        QTest::newRow("should FAIL: -inf != -max") << -uge << -big;
-        QTest::newRow("should FAIL: max != -inf") << big << -uge;
-        QTest::newRow("should FAIL: -max != -inf") << -big << -uge;
-    }
+    nonFinite_data(zero, one);
 }
 
 void tst_float::floatComparisons() const
@@ -131,65 +141,26 @@ void tst_float::floatComparisons_data() const
 {
     QTest::addColumn<float>("operandLeft");
     QTest::addColumn<float>("operandRight");
+    float zero(0.f), one(1.f);
 
-    QTest::newRow("should FAIL 1") << 1.00000f << 3.00000f;
-    QTest::newRow("should PASS 1") << 0.f << 0.f;
-    QTest::newRow("should FAIL 2") << 1.00000e-7f << 3.00000e-7f;
+    QTest::newRow("should FAIL 1") << one << 3.f;
+    QTest::newRow("should PASS 1") << zero << zero;
+    QTest::newRow("should FAIL 2") << 1.e-7f << 3.e-7f;
 
     // QCOMPARE for floats uses qFuzzyCompare(), which succeeds if the numbers
     // differ by no more than 1e-5 times the smaller value.  Thus
     // QCOMPARE(1e5-2, 1e5-1) should fail, while QCOMPARE(1e5+1, 1e5+2)
     // should pass.
 
-    QTest::newRow("should PASS 2") << 1e5f + 1.f << 1e5f + 2.f;
-    QTest::newRow("should FAIL 3") << 1e5f - 1.f << 1e5f - 2.f;
+    QTest::newRow("should PASS 2") << 1e5f + one << 1e5f + 2.f;
+    QTest::newRow("should FAIL 3") << 1e5f - one << 1e5f - 2.f;
     // ... but rounding makes that a bit unrelaible when scaled close to the bounds.
     QTest::newRow("should PASS 3") << 1e-39f + 1e-44f << 1e-39f + 2e-44f;
     QTest::newRow("should FAIL 4") << 1e-39f - 1e-44f << 1e-39f - 3e-44f;
     QTest::newRow("should PASS 4") << 1e38f + 1e33f << 1e38f + 2e33f;
     QTest::newRow("should FAIL 5") << 1e38f - 1e33f << 1e38f - 3e33f;
 
-    // QCOMPARE special-cases non-finite values
-    if (std::numeric_limits<float>::has_quiet_NaN) {
-        const float nan = std::numeric_limits<float>::quiet_NaN();
-        QTest::newRow("should PASS: NaN == NaN") << nan << nan;
-        QTest::newRow("should FAIL: NaN != 0") << nan << 0.f;
-        QTest::newRow("should FAIL: 0 != NaN") << 0.f << nan;
-        QTest::newRow("should FAIL: NaN != 1") << nan << 1.f;
-        QTest::newRow("should FAIL: 1 != NaN") << 1.f << nan;
-    }
-    if (std::numeric_limits<float>::has_infinity) {
-        const float uge = std::numeric_limits<float>::infinity();
-        QTest::newRow("should PASS: inf == inf") << uge << uge;
-        QTest::newRow("should PASS: -inf == -inf") << -uge << -uge;
-        QTest::newRow("should FAIL: inf != -inf") << uge << -uge;
-        QTest::newRow("should FAIL: -inf != inf") << -uge << uge;
-        if (std::numeric_limits<float>::has_quiet_NaN) {
-            const float nan = std::numeric_limits<float>::quiet_NaN();
-            QTest::newRow("should FAIL: inf != nan") << uge << nan;
-            QTest::newRow("should FAIL: nan != inf") << nan << uge;
-            QTest::newRow("should FAIL: -inf != nan") << -uge << nan;
-            QTest::newRow("should FAIL: nan != -inf") << nan << -uge;
-        }
-        QTest::newRow("should FAIL: inf != 0") << uge << 0.f;
-        QTest::newRow("should FAIL: 0 != inf") << 0.f << uge;
-        QTest::newRow("should FAIL: -inf != 0") << -uge << 0.f;
-        QTest::newRow("should FAIL: 0 != -inf") << 0.f << -uge;
-        QTest::newRow("should FAIL: inf != 1") << uge << 1.f;
-        QTest::newRow("should FAIL: 1 != inf") << 1.f << uge;
-        QTest::newRow("should FAIL: -inf != 1") << -uge << 1.f;
-        QTest::newRow("should FAIL: 1 != -inf") << 1.f << -uge;
-
-        const float big = std::numeric_limits<float>::max();
-        QTest::newRow("should FAIL: inf != max") << uge << big;
-        QTest::newRow("should FAIL: inf != -max") << uge << -big;
-        QTest::newRow("should FAIL: max != inf") << big << uge;
-        QTest::newRow("should FAIL: -max != inf") << -big << uge;
-        QTest::newRow("should FAIL: -inf != max") << -uge << big;
-        QTest::newRow("should FAIL: -inf != -max") << -uge << -big;
-        QTest::newRow("should FAIL: max != -inf") << big << -uge;
-        QTest::newRow("should FAIL: -max != -inf") << -big << -uge;
-    }
+    nonFinite_data(zero, one);
 }
 
 void tst_float::float16Comparisons() const