QtWidgets tests: port remaining users away from Q_FOREACH

These are all trivial: all are over (already or newly-made) const
local variables.

As a drive-by, replace a QList legacy left-shift-based- with
initializer_list-construction.

Pick-to: 6.6 6.5
Task-number: QTBUG-115803
Change-Id: I453e24272c4c4b7dce5b91a0bd04481d833c50bb
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>

2 files changed, 8 insertions, 5 deletions

diff --git a/tests/auto/widgets/graphicsview/qgraphicsproxywidget/tst_qgraphicsproxywidget.cpp b/tests/auto/widgets/graphicsview/qgraphicsproxywidget/tst_qgraphicsproxywidget.cpp
index 4562ac3a84..0224f7aa7e 100644
--- a/tests/auto/widgets/graphicsview/qgraphicsproxywidget/tst_qgraphicsproxywidget.cpp
+++ b/tests/auto/widgets/graphicsview/qgraphicsproxywidget/tst_qgraphicsproxywidget.cpp
@@ -2476,7 +2476,8 @@ void tst_QGraphicsProxyWidget::tooltip_basic()
 
         bool foundView = false;
         bool foundTipLabel = false;
-        foreach (QWidget *widget, QApplication::topLevelWidgets()) {
+        const auto widgets = QApplication::topLevelWidgets();
+        for (QWidget *widget : widgets) {
             if (widget == &view)
                 foundView = true;
             if (widget->inherits("QTipLabel"))
diff --git a/tests/auto/widgets/graphicsview/qgraphicsview/tst_qgraphicsview.cpp b/tests/auto/widgets/graphicsview/qgraphicsview/tst_qgraphicsview.cpp
index 27fbcc2b3b..bfb628d7a3 100644
--- a/tests/auto/widgets/graphicsview/qgraphicsview/tst_qgraphicsview.cpp
+++ b/tests/auto/widgets/graphicsview/qgraphicsview/tst_qgraphicsview.cpp
@@ -1049,9 +1049,9 @@ void tst_QGraphicsView::rotated_rubberBand()
     sendMouseMove(view.viewport(), QPoint(midWidth + 2, view.viewport()->height()),
                   Qt::LeftButton, Qt::LeftButton);
     QCOMPARE(scene.selectedItems().size(), dim);
-    foreach (const QGraphicsItem *item, scene.items()) {
+    const auto items = scene.items();
+    for (const QGraphicsItem *item : items)
         QCOMPARE(item->isSelected(), item->data(0).toBool());
-    }
     sendMouseRelease(view.viewport(), QPoint(), Qt::LeftButton);
 }
 
@@ -2739,7 +2739,8 @@ void tst_QGraphicsView::optimizationFlags_dontSavePainterState2()
     rectB->setTransform(QTransform::fromTranslate(200, 200));
     rectB->setPen(QPen(Qt::black, 0));
 
-    foreach (QGraphicsItem *item, scene.items())
+    const auto items = scene.items();
+    for (QGraphicsItem *item : items)
         item->setOpacity(0.6);
 
     CustomView view(&scene);
@@ -3258,7 +3259,8 @@ protected:
     {
         ++mouseMoves;
         QGraphicsView::mouseMoveEvent(event);
-        foreach (QGraphicsItem *item, scene()->items()) {
+        const auto items = scene()->items();
+        for (QGraphicsItem *item : items) {
             scene()->removeItem(item);
             delete item;
         }