diff options
author | Jason McDonald <jason.mcdonald@nokia.com> | 2011-11-15 11:36:18 +1000 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2011-11-18 01:51:57 +0100 |
commit | a8fd0c3654f8352773638633778cd8003680cbc7 (patch) | |
tree | 4815cca9daf879b96a92a3de95621b56ac5ba868 /tests/auto/widgets/itemviews/qdirmodel/tst_qdirmodel.cpp | |
parent | d90d57bb8b995c7a66e7f9b7b2515447fbe11de0 (diff) |
Don't depend on moc to disable test functions.
The moc tool is not aware of all defines (particularly those that are
compiler builtins) and does not correctly evaluate others that depend
on compiler builtins, such as Q_OS_FOO.
This commit reverts parts of the following commits, but is not a
complete fix as there were many instances of this problem in the tests
prior to those commits:
924d810dbdcd5b5b0fa860922b2487ea9062d002
8aaff6751038b88d17e23be6fcee945771297c5b
338d3f11973412047c2c9cd41cbd0c961d738ef3
a55034062ba2bf73a9f1ed3d9cf31745b38149e3
253497b7446c7d723aa3bdd7152e25d6852f2604
7cfad460c56319ba89c4a3a0bbcb2e54ab1cdbc6
9d2ff58f3642828e494e7e9b2df7dbb8e2cd408f
0cf6baa2d61ebaad2a2a0530c37f27e719b68f4b
Change-Id: I947d797fe3ec76139ba1b55561cea569895662c5
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Diffstat (limited to 'tests/auto/widgets/itemviews/qdirmodel/tst_qdirmodel.cpp')
-rw-r--r-- | tests/auto/widgets/itemviews/qdirmodel/tst_qdirmodel.cpp | 22 |
1 files changed, 10 insertions, 12 deletions
diff --git a/tests/auto/widgets/itemviews/qdirmodel/tst_qdirmodel.cpp b/tests/auto/widgets/itemviews/qdirmodel/tst_qdirmodel.cpp index 00fc1bd1df..65900a4bed 100644 --- a/tests/auto/widgets/itemviews/qdirmodel/tst_qdirmodel.cpp +++ b/tests/auto/widgets/itemviews/qdirmodel/tst_qdirmodel.cpp @@ -54,14 +54,10 @@ class tst_QDirModel : public QObject Q_OBJECT public slots: void cleanupTestCase(); -#ifdef Q_OS_UNIX void init(); -#endif private slots: void getSetCheck(); -#ifdef Q_OS_UNIX void unreadable(); -#endif /* void construct(); void rowCount(); @@ -87,9 +83,7 @@ private slots: void filePath(); -#ifdef Q_OS_UNIX void hidden(); -#endif void fileName(); void fileName_data(); @@ -140,9 +134,9 @@ void tst_QDirModel::cleanupTestCase() current.rmdir(".qtest_hidden"); } -#ifdef Q_OS_UNIX void tst_QDirModel::init() { +#ifdef Q_OS_UNIX if (QTest::currentTestFunction() == QLatin1String( "unreadable" )) { // Make sure that the unreadable file created by the unreadable() // test function doesn't already exist. @@ -152,8 +146,8 @@ void tst_QDirModel::init() QVERIFY(!unreadableFile.exists()); } } -} #endif +} /* tests @@ -502,9 +496,11 @@ void tst_QDirModel::rowsAboutToBeRemoved() QVERIFY(rowsAboutToBeRemoved_cleanup(test_path)); } -#ifdef Q_OS_UNIX void tst_QDirModel::hidden() { +#ifndef Q_OS_UNIX + QSKIP("Test not implemented on non-Unixes"); +#else QDir current; current.mkdir(".qtest_hidden"); @@ -520,8 +516,8 @@ void tst_QDirModel::hidden() model2.setFilter(model2.filter() | QDir::Hidden); index = model2.index(QDir::currentPath() + "/.qtest_hidden"); QVERIFY(index.isValid()); -} #endif +} void tst_QDirModel::fileName_data() { @@ -543,9 +539,11 @@ void tst_QDirModel::fileName() QCOMPARE(model.fileName(model.index(path)), result); } -#ifdef Q_OS_UNIX void tst_QDirModel::unreadable() { +#ifndef Q_OS_UNIX + QSKIP("Test not implemented on non-Unixes"); +#else // Create an empty file which has no read permissions (file will be removed by cleanup()). QFile unreadableFile(QDir::currentPath() + "qtest_unreadable"); QVERIFY2(unreadableFile.open(QIODevice::WriteOnly | QIODevice::Text), qPrintable(unreadableFile.errorString())); @@ -563,8 +561,8 @@ void tst_QDirModel::unreadable() model2.setFilter(model2.filter() | QDir::Hidden); index = model2.index(QDir::currentPath() + "/qtest_unreadable"); QVERIFY(!index.isValid()); -} #endif +} void tst_QDirModel::filePath() { |