Long live QTest::addRow()!

This new function does the same as newRow(), except that it has a less confusing
name (in line with _add_Column()), and accepts printf-style arguments to avoid
the need to newRow(qPrintable(QString::asprintf())), a common pattern in client
code. It uses qvsnprintf() under the hoods, avoiding the need for the QString
const char* round-trip.

Port all in-tree users of newRow(qPrintable(QString::asnprintf())) to the new
function.

Change-Id: Icd5de9b7ea4f6759d98080ec30f5aecadb8bec39
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/tests/auto/widgets/kernel/qsizepolicy/tst_qsizepolicy.cpp b/tests/auto/widgets/kernel/qsizepolicy/tst_qsizepolicy.cpp
index 9e5fc55379..cd5aa03689 100644
--- a/tests/auto/widgets/kernel/qsizepolicy/tst_qsizepolicy.cpp
+++ b/tests/auto/widgets/kernel/qsizepolicy/tst_qsizepolicy.cpp
@@ -151,10 +151,10 @@ static void makeRow(QSizePolicy sp, QSizePolicy::Policy hp, QSizePolicy::Policy
                     int hst, int vst, QSizePolicy::ControlType ct, bool hfw, bool wfh,
                     Qt::Orientations orients)
 {
-    QTest::newRow(qPrintable(QString::asprintf("%s-%s-%d-%d-%s-%s-%s",
-                                               PrettyPrint(hp).s(), PrettyPrint(vp).s(), hst, vst,
-                                               PrettyPrint(ct).s(),
-                                               hfw ? "true" : "false", wfh ? "true" : "false")))
+    QTest::addRow("%s-%s-%d-%d-%s-%s-%s",
+                  PrettyPrint(hp).s(), PrettyPrint(vp).s(), hst, vst,
+                  PrettyPrint(ct).s(),
+                  hfw ? "true" : "false", wfh ? "true" : "false")
             << sp << hp << vp << hst << vst << ct << hfw << wfh << orients;
 }