|author||Jędrzej Nowacki <email@example.com>||2012-11-02 13:59:04 +0100|
|committer||The Qt Project <firstname.lastname@example.org>||2012-11-03 11:20:26 +0100|
Fix conditional jump based on an uninitialized variable.
Valgrind warns about the jump in qfontconfigdatabase.cpp:522 based on uint QFondDef::hintingPreference:2 property. Surprising thing is that the property is initialized in the default constructor, so there should not be an issue. The warning disappear if the property is _not_ placed on a boundary of a two words, or if bit field is fully initialized. So I suspect that only one bit of the two was initialized properly. I decide to implement both solutions because of a potential minor performance improvement, during reading the property. I still fail to say why the value was uninitialized, I believe that this patch simply workarounds gcc bug or valgrind bug. Change-Id: I2e87738f66a435ef6e30b3d2db6baa73da025426 Reviewed-by: Jiang Jiang <email@example.com> Reviewed-by: Eskil Abrahamsen Blomfeldt <firstname.lastname@example.org> Reviewed-by: Konstantin Ritt <email@example.com>
Diffstat (limited to 'tests/auto/widgets/styles/qstyle/tst_qstyle.cpp')
0 files changed, 0 insertions, 0 deletions