summaryrefslogtreecommitdiffstats
path: root/tests/auto
diff options
context:
space:
mode:
authorVolker Hilsheimer <volker.hilsheimer@qt.io>2021-10-21 12:03:57 +0200
committerVolker Hilsheimer <volker.hilsheimer@qt.io>2021-10-22 09:43:53 +0200
commit71aaf831d175a164b508ce169131a794d55d6fb0 (patch)
treec7c3edd7b90c7b9e66e28dedafdc5f6c2f8bf9b4 /tests/auto
parent7d133a5613b7d9bae544fa56d26577c0c9d50ff4 (diff)
QAbstractItemView: auto-scroll with selection rectangle
Some item views, such as QListView in icon mode, implement a selection rectangle with which the user can "lasso" items. So far, dragging that rectangle did not trigger auto scroll, so unless an item near the edge was selected, the user had to stop the lassoing and scroll manually to reach more items. Since QAbtractItemView implements auto scrolling for drag'n'drop, we can use that mechanism also when the selection rectangle is dragged. This requires some modifications: We need to make sure that scrolling the view during a drag-selection generates mouse move events so that the selection is extended and the rectangle is updated in subclasses. And we need to stop using QCursor::pos to get the position of the mouse pointer, as this makes the auto-scrolling untestable. Instead, record the mouse position last seen during a mouseMove or dragMoveEvent in content-coordinates (identical to pressedPosition). As a drive-by, fix some coding-style issues in nearby code. Done-with: Zhang Hao <zhanghao@uniontech.com> Fixes: QTBUG-96124 Change-Id: I426f786e5842ae9f9fb04e9d34dc6d3379a6207f Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
Diffstat (limited to 'tests/auto')
-rw-r--r--tests/auto/widgets/itemviews/qabstractitemview/qtlogo.pngbin0 -> 2991 bytes
-rw-r--r--tests/auto/widgets/itemviews/qabstractitemview/tst_qabstractitemview.cpp117
2 files changed, 117 insertions, 0 deletions
diff --git a/tests/auto/widgets/itemviews/qabstractitemview/qtlogo.png b/tests/auto/widgets/itemviews/qabstractitemview/qtlogo.png
new file mode 100644
index 0000000000..4f68e162de
--- /dev/null
+++ b/tests/auto/widgets/itemviews/qabstractitemview/qtlogo.png
Binary files differ
diff --git a/tests/auto/widgets/itemviews/qabstractitemview/tst_qabstractitemview.cpp b/tests/auto/widgets/itemviews/qabstractitemview/tst_qabstractitemview.cpp
index d904f97d82..547d120bca 100644
--- a/tests/auto/widgets/itemviews/qabstractitemview/tst_qabstractitemview.cpp
+++ b/tests/auto/widgets/itemviews/qabstractitemview/tst_qabstractitemview.cpp
@@ -166,6 +166,8 @@ private slots:
void scrollerSmoothScroll();
void inputMethodOpensEditor_data();
void inputMethodOpensEditor();
+ void selectionAutoScrolling_data();
+ void selectionAutoScrolling();
private:
static QAbstractItemView *viewFromString(const QByteArray &viewType, QWidget *parent = nullptr)
@@ -3177,5 +3179,120 @@ void tst_QAbstractItemView::inputMethodOpensEditor()
}
}
+void tst_QAbstractItemView::selectionAutoScrolling_data()
+{
+ QTest::addColumn<Qt::Orientation>("orientation");
+ QTest::addColumn<int>("direction"); // negative or positive
+
+ QTest::addRow("scroll up") << Qt::Vertical << -1;
+ QTest::addRow("scroll left") << Qt::Horizontal << -1;
+ QTest::addRow("scroll down") << Qt::Vertical << +1;
+ QTest::addRow("scroll right") << Qt::Horizontal << +1;
+}
+
+void tst_QAbstractItemView::selectionAutoScrolling()
+{
+ QFETCH(Qt::Orientation, orientation);
+ QFETCH(int, direction);
+
+ QListView listview;
+ listview.setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding);
+ listview.setResizeMode(QListView::Fixed);
+ listview.setAutoScroll(true);
+ listview.setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
+ listview.setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
+ listview.setSpacing(10);
+ listview.setGeometry(0, 0, 500, 500);
+ listview.setFrameShape(QFrame::Shape::NoFrame);
+ listview.setEditTriggers(QListView::NoEditTriggers);
+
+ QStandardItemModel *listModel = new QStandardItemModel(&listview);
+ listview.setModel(listModel);
+ listview.setViewMode(QListView::IconMode);
+ listview.setSelectionMode(QListView::ExtendedSelection);
+
+ QPixmap pm(50, 50);
+ pm.fill(Qt::red);
+ for (int i = 0; i < 80; i++) {
+ QStandardItem *item = new QStandardItem(pm, QString::number(i));
+ listModel->appendRow(item);
+ }
+
+ listview.show();
+ QVERIFY(QTest::qWaitForWindowExposed(&listview));
+
+ listview.resize(200, 200);
+ // scroll to the middle
+ listview.verticalScrollBar()->setValue(listview.verticalScrollBar()->maximum() / 2);
+ listview.horizontalScrollBar()->setValue(listview.horizontalScrollBar()->maximum() / 2);
+
+ // remove all visible items so that we don't select any items at the edges, as that
+ // would scroll the view already
+ for (int x = 0; x < listview.viewport()->width(); x += 5) {
+ for (int y = 0; y < listview.viewport()->height(); y += 5) {
+ const QModelIndex index = listview.indexAt(QPoint(x, y));
+ if (index.isValid())
+ delete listModel->itemFromIndex(index);
+ }
+ }
+ // remove all items around the edges of the model
+ QRect topLeftRect = listview.visualRect(listModel->index(0, 0));
+ const QPoint topLeftCenter(topLeftRect.center());
+ QPoint bottomRightCenter;
+ for (int x = 0; x < listview.horizontalScrollBar()->maximum() + listview.viewport()->width(); x += 5) {
+ const QModelIndex index = listview.indexAt(topLeftCenter + QPoint(x, 0));
+ if (index.isValid()) {
+ delete listModel->itemFromIndex(index);
+ bottomRightCenter.rx() = x;
+ }
+ }
+ for (int y = 0; y < listview.verticalScrollBar()->maximum() + listview.viewport()->height(); y += 5) {
+ const QModelIndex index = listview.indexAt(topLeftCenter + QPoint(0, y));
+ if (index.isValid()) {
+ delete listModel->itemFromIndex(index);
+ bottomRightCenter.ry() = y;
+ }
+ }
+ for (int x = 0; x < bottomRightCenter.x(); x += 5) {
+ const QModelIndex index = listview.indexAt(topLeftCenter + QPoint(x, bottomRightCenter.y()));
+ if (index.isValid())
+ delete listModel->itemFromIndex(index);
+ }
+ for (int y = 0; y < bottomRightCenter.y(); y += 5) {
+ const QModelIndex index = listview.indexAt(topLeftCenter + QPoint(bottomRightCenter.x(), y));
+ if (index.isValid())
+ delete listModel->itemFromIndex(index);
+ }
+
+
+ // Simulate multiple select behavior; start in the middle, drag to the edge
+ const QPoint pressPoint(listview.viewport()->width() / 2, listview.viewport()->height() / 2);
+ QPoint dragPoint = pressPoint;
+ if (orientation == Qt::Vertical) {
+ dragPoint.rx() += 50;
+ dragPoint.ry() = direction > 0 ? listview.viewport()->height() : 0;
+ } else {
+ dragPoint.rx() = direction > 0 ? listview.viewport()->width() : 0;
+ dragPoint.ry() += 50;
+ }
+
+ QTest::mousePress(listview.viewport(), Qt::LeftButton, Qt::NoModifier, pressPoint);
+ QMouseEvent mmEvent(QEvent::MouseMove, dragPoint, Qt::NoButton, Qt::LeftButton, Qt::NoModifier);
+ QApplication::sendEvent(listview.viewport(), &mmEvent); // QTest::mouseMove is useless
+
+ // check that we scrolled to the end
+ QScrollBar *scrollBar = orientation == Qt::Vertical
+ ? listview.verticalScrollBar()
+ : listview.horizontalScrollBar();
+
+ if (direction < 0)
+ QTRY_COMPARE(scrollBar->value(), 0);
+ else
+ QTRY_COMPARE(scrollBar->value(), scrollBar->maximum());
+ QVERIFY(listview.selectionModel()->selectedIndexes().count() > 0);
+
+ QTest::mouseRelease(listview.viewport(), Qt::LeftButton, Qt::NoModifier, dragPoint);
+}
+
QTEST_MAIN(tst_QAbstractItemView)
#include "tst_qabstractitemview.moc"