summaryrefslogtreecommitdiffstats
path: root/tests/benchmarks/corelib/tools/qvector/qrawvector.h
diff options
context:
space:
mode:
authorEdward Welbourne <edward.welbourne@qt.io>2021-07-08 15:39:41 +0200
committerEdward Welbourne <edward.welbourne@qt.io>2021-07-19 18:55:51 +0200
commit406bb11a4ebf3e166416a399807ec2ad8d1baede (patch)
tree8ea2b2b690e445d543dd03e67322533a765bd852 /tests/benchmarks/corelib/tools/qvector/qrawvector.h
parent1969a25ceef1be7b9769245054c80e5b56491820 (diff)
Suppress a broken benchmark comparing QVector to std::vector
The test constructs an ersatz object with which to overwrite a QVector's internals, but based it on Qt 5's memory layout. Since Qt 6 completely rearranged that memory layout, the test now crashes (or, in a debug build, trips over an out-of-bounds assertion). So suppress the test until those who perpetrated it and/or the reworking of QVector's internals can work out how to fix it. That way, QA can at least run the benchmark without crashing. Task-number: QTBUG-95061 Pick-to: 6.2 Change-Id: I0e8c8d58f2002497f6e29d0ad25f840e207704a4 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Diffstat (limited to 'tests/benchmarks/corelib/tools/qvector/qrawvector.h')
-rw-r--r--tests/benchmarks/corelib/tools/qvector/qrawvector.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/tests/benchmarks/corelib/tools/qvector/qrawvector.h b/tests/benchmarks/corelib/tools/qvector/qrawvector.h
index 1f615f6e69..3d827c7921 100644
--- a/tests/benchmarks/corelib/tools/qvector/qrawvector.h
+++ b/tests/benchmarks/corelib/tools/qvector/qrawvector.h
@@ -217,6 +217,7 @@ private:
public:
QVector<T> mutateToVector()
{
+ Q_ASSERT(!"Fix QTBUG-95061 before calling this; it is broken beyond repair");
Data *d = toBase(m_begin);
d->ref.initializeOwned();
d->alloc = m_alloc;