summaryrefslogtreecommitdiffstats
path: root/tests/benchmarks/corelib
diff options
context:
space:
mode:
authorVolker Hilsheimer <volker.hilsheimer@qt.io>2023-03-04 11:20:36 +0100
committerVolker Hilsheimer <volker.hilsheimer@qt.io>2023-03-21 07:46:27 +0100
commit643b6e5b291669c0decda1ed827ec2a98cfc6e29 (patch)
treef0c659d9e753d5b7255a7a841e30c8fd9b2f7835 /tests/benchmarks/corelib
parent617165af6b3a317ec40f130ccadff81684171c34 (diff)
Silence warnings from unused variables
Use them, or replace them with existing constants. Pick-to: 6.5 Change-Id: I808028296305e15b68aecb1f961ba6a85b8e9cc7 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> Reviewed-by: Øystein Heskestad <oystein.heskestad@qt.io> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Diffstat (limited to 'tests/benchmarks/corelib')
-rw-r--r--tests/benchmarks/corelib/kernel/events/tst_bench_events.cpp1
-rw-r--r--tests/benchmarks/corelib/thread/qthreadstorage/tst_bench_qthreadstorage.cpp1
-rw-r--r--tests/benchmarks/corelib/time/qdatetime/CMakeLists.txt1
-rw-r--r--tests/benchmarks/corelib/time/qdatetime/tst_bench_qdatetime.cpp4
4 files changed, 5 insertions, 2 deletions
diff --git a/tests/benchmarks/corelib/kernel/events/tst_bench_events.cpp b/tests/benchmarks/corelib/kernel/events/tst_bench_events.cpp
index 0b310afb94..b6fa503d1d 100644
--- a/tests/benchmarks/corelib/kernel/events/tst_bench_events.cpp
+++ b/tests/benchmarks/corelib/kernel/events/tst_bench_events.cpp
@@ -88,6 +88,7 @@ void EventsBench::noEvent()
QBENCHMARK {
val += tst.foo(1);
}
+ QVERIFY(val > 0);
}
void EventsBench::sendEvent_data()
diff --git a/tests/benchmarks/corelib/thread/qthreadstorage/tst_bench_qthreadstorage.cpp b/tests/benchmarks/corelib/thread/qthreadstorage/tst_bench_qthreadstorage.cpp
index 1361013833..724d587dd1 100644
--- a/tests/benchmarks/corelib/thread/qthreadstorage/tst_bench_qthreadstorage.cpp
+++ b/tests/benchmarks/corelib/thread/qthreadstorage/tst_bench_qthreadstorage.cpp
@@ -64,6 +64,7 @@ void tst_QThreadStorage::get()
int *i = ts.localData();
count += *i;
}
+ QVERIFY(count > 0);
ts.setLocalData(0);
}
diff --git a/tests/benchmarks/corelib/time/qdatetime/CMakeLists.txt b/tests/benchmarks/corelib/time/qdatetime/CMakeLists.txt
index 9fe26fe5e1..14c0b9c730 100644
--- a/tests/benchmarks/corelib/time/qdatetime/CMakeLists.txt
+++ b/tests/benchmarks/corelib/time/qdatetime/CMakeLists.txt
@@ -10,4 +10,5 @@ qt_internal_add_benchmark(tst_bench_qdatetime
tst_bench_qdatetime.cpp
LIBRARIES
Qt::Test
+ Qt::CorePrivate
)
diff --git a/tests/benchmarks/corelib/time/qdatetime/tst_bench_qdatetime.cpp b/tests/benchmarks/corelib/time/qdatetime/tst_bench_qdatetime.cpp
index 1213f3b133..822477c8fd 100644
--- a/tests/benchmarks/corelib/time/qdatetime/tst_bench_qdatetime.cpp
+++ b/tests/benchmarks/corelib/time/qdatetime/tst_bench_qdatetime.cpp
@@ -6,6 +6,7 @@
#include <QTest>
#include <QList>
#include <qdebug.h>
+#include <QtCore/private/qdatetime_p.h>
class tst_QDateTime : public QObject
{
@@ -67,8 +68,7 @@ private Q_SLOTS:
void fromMSecsSinceEpochTz();
};
-constexpr qint64 SECS_PER_DAY = 86400;
-constexpr qint64 MSECS_PER_DAY = 86400000;
+using namespace QtPrivate::DateTimeConstants;
constexpr qint64 JULIAN_DAY_1 = 1721426;
constexpr qint64 JULIAN_DAY_11 = 1725078;
constexpr qint64 JULIAN_DAY_1890 = 2411369;