Avoid using QSKIP in lieu of compile-time checks

QSKIP is intended to be used to skip test functions that are found at
run-time to be inapplicable or unsafe.  If a test function can be
determined to be inapplicable at compile-time, the entire test function
should be omitted instead of replacing the body of the test function
with a QSKIP, which only serves to slow down test runs and to inflate
test run-rates with empty, inapplicable tests.

Task-number: QTQAINFRA-278

Change-Id: I95feba3edbfa092c0ef4d85bb8c6877bd6be698e
Reviewed-on: http://codereview.qt-project.org/6128
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>

1 files changed, 5 insertions, 3 deletions

diff --git a/tests/benchmarks/network/socket/qtcpserver/tst_qtcpserver.cpp b/tests/benchmarks/network/socket/qtcpserver/tst_qtcpserver.cpp
index abf4f14894..842e2750b0 100644
--- a/tests/benchmarks/network/socket/qtcpserver/tst_qtcpserver.cpp
+++ b/tests/benchmarks/network/socket/qtcpserver/tst_qtcpserver.cpp
@@ -74,7 +74,9 @@ public slots:
     void cleanup();
 private slots:
     void ipv4LoopbackPerformanceTest();
+#ifndef Q_WS_WINCE_WM
     void ipv6LoopbackPerformanceTest();
+#endif
     void ipv4PerformanceTest();
 };
 
@@ -165,14 +167,13 @@ void tst_QTcpServer::ipv4LoopbackPerformanceTest()
 }
 
 //----------------------------------------------------------------------------------
+// IPv6 loopback not yet supported on Windows Mobile
+#ifndef Q_WS_WINCE_WM
 void tst_QTcpServer::ipv6LoopbackPerformanceTest()
 {
     QFETCH_GLOBAL(bool, setProxy);
     if (setProxy)
         return;
-#if defined(Q_WS_WINCE_WM)
-    QSKIP("WinCE WM: Not yet supported", SkipAll);
-#endif
 
     QTcpServer server;
     if (!server.listen(QHostAddress::LocalHostIPv6, 0)) {
@@ -217,6 +218,7 @@ void tst_QTcpServer::ipv6LoopbackPerformanceTest()
         delete clientB;
     }
 }
+#endif
 
 //----------------------------------------------------------------------------------
 void tst_QTcpServer::ipv4PerformanceTest()