diff options
| author | Marc Mutz <marc.mutz@qt.io> | 2023-08-08 07:37:03 +0200 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@qt.io> | 2023-08-08 18:57:40 +0200 |
| commit | ba4b88d9d2f1dd03906f445c55f8959e0165505f (patch) | |
| tree | ac071402a803c1ee0e568a9a632e75cb57ada582 /tests/manual/qsslsocket | |
| parent | 5cf3d062f66677e77c0e288ba5544c6a835398e5 (diff) | |
QSslSocket manual test: replace QList with const array
"Never use a dynamically-sized container for statically-sized data."
Port the loop from Q_FOREACH (which can't deal with arrays) to ranged
for (which can).
Pick-to: 6.6 6.5
Task-number: QTBUG-115839
Change-Id: Ib89d07fb751e3905a230ee5641e2e509e9415bed
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Diffstat (limited to 'tests/manual/qsslsocket')
| -rw-r--r-- | tests/manual/qsslsocket/main.cpp | 17 |
1 files changed, 9 insertions, 8 deletions
diff --git a/tests/manual/qsslsocket/main.cpp b/tests/manual/qsslsocket/main.cpp index 2894b3c1fa..e7f5e91997 100644 --- a/tests/manual/qsslsocket/main.cpp +++ b/tests/manual/qsslsocket/main.cpp @@ -30,14 +30,15 @@ void tst_QSslSocket::nextProtocolNegotiation_data() QTest::addColumn<QByteArray>("expectedProtocol"); QTest::addColumn<QSslConfiguration::NextProtocolNegotiationStatus>("expectedStatus"); - QList<QString> hosts = QList<QString>() - << QStringLiteral("www.google.com") - << QStringLiteral("www.facebook.com") - << QStringLiteral("www.twitter.com") - << QStringLiteral("graph.facebook.com") - << QStringLiteral("api.twitter.com"); - - foreach (QString host, hosts) { + const QString hosts[] = { + QStringLiteral("www.google.com"), + QStringLiteral("www.facebook.com"), + QStringLiteral("www.twitter.com"), + QStringLiteral("graph.facebook.com"), + QStringLiteral("api.twitter.com"), + }; + + for (const QString &host : hosts) { QByteArray tag = host.toLocal8Bit(); tag.append("-none"); QTest::newRow(tag) |