diff options
| author | Edward Welbourne <edward.welbourne@qt.io> | 2021-11-24 17:34:37 +0100 |
|---|---|---|
| committer | Edward Welbourne <edward.welbourne@qt.io> | 2021-11-26 02:14:52 +0100 |
| commit | 0cad974d0da72e96944108df2face676f5ec250d (patch) | |
| tree | af4a88c2bfa794e867941c33b18c01df7998bb89 /tests | |
| parent | 6437bd240f64a60e376ff3c5432c9d7e53072782 (diff) | |
Add a note to save the next reader some confusion
I was briefly confused about why an Etc/GMT+3 test was using GMT as
localtime. Fortunately I worked it out before mis-"correcting" it.
Change-Id: I7b0473c7d3974ef186e1170cf4999aca52aaaf45
Reviewed-by: Andreas Buhr <andreas.buhr@qt.io>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/auto/corelib/time/qdatetime/tst_qdatetime.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/tests/auto/corelib/time/qdatetime/tst_qdatetime.cpp b/tests/auto/corelib/time/qdatetime/tst_qdatetime.cpp index b8f61ea8fd..1b12abdcf9 100644 --- a/tests/auto/corelib/time/qdatetime/tst_qdatetime.cpp +++ b/tests/auto/corelib/time/qdatetime/tst_qdatetime.cpp @@ -2905,6 +2905,10 @@ void tst_QDateTime::fromStringStringFormat_localTimeZone_data() bool lacksRows = true; #if QT_CONFIG(timezone) + // Note that the localTimeZone needn't match the zone used in the string and + // expected date-time; indeed, having them different is probably best. + // Both zones need to be valid; GMT always is, so is a safe one to use for + // whichever the test-case doesn't care about (if that applies to either). QTimeZone etcGmtWithOffset("Etc/GMT+3"); if (etcGmtWithOffset.isValid()) { lacksRows = false; |