summaryrefslogtreecommitdiffstats
path: root/tests
diff options
context:
space:
mode:
authorLars Knoll <lars.knoll@qt.io>2020-07-07 21:34:57 +0200
committerLars Knoll <lars.knoll@qt.io>2020-07-10 15:07:02 +0200
commit0d1208f0f08727c55de9eed8e0ceef092080b927 (patch)
tree2aa935c4c8917320f84fceb43af1716c72e26329 /tests
parent4e400369c08db251cd489fec1229398c224d02b4 (diff)
Cleanup QPropertyBindingError
Remove location(). The method would always return an empty value. If you need the location, the binding itself has it. Remove setDescription() and require that the description gets passed in the constructor. Never create a d pointer if type is NoError, so we can quickly check for it inline. Change-Id: I7eb8a94786281069d6ea2d82567c09aa50c52ef6 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'tests')
-rw-r--r--tests/auto/corelib/kernel/qproperty/tst_qproperty.cpp3
1 files changed, 1 insertions, 2 deletions
diff --git a/tests/auto/corelib/kernel/qproperty/tst_qproperty.cpp b/tests/auto/corelib/kernel/qproperty/tst_qproperty.cpp
index 96cf6da4bb..50a8d51a46 100644
--- a/tests/auto/corelib/kernel/qproperty/tst_qproperty.cpp
+++ b/tests/auto/corelib/kernel/qproperty/tst_qproperty.cpp
@@ -506,8 +506,7 @@ void tst_QProperty::bindingSourceLocation()
void tst_QProperty::bindingError()
{
QProperty<int> prop = Qt::makePropertyBinding([]() -> std::variant<int, QPropertyBindingError> {
- QPropertyBindingError error(QPropertyBindingError::UnknownError);
- error.setDescription(QLatin1String("my error"));
+ QPropertyBindingError error(QPropertyBindingError::UnknownError, QLatin1String("my error"));
return error;
});
QCOMPARE(prop.value(), 0);