diff options
| author | Andreas Buhr <andreas.buhr@qt.io> | 2020-09-09 20:04:59 +0200 |
|---|---|---|
| committer | Andreas Buhr <andreas.buhr@qt.io> | 2020-09-11 06:12:13 +0200 |
| commit | 3a1dad83ed97583551fa2fd8bf73986cd941f063 (patch) | |
| tree | a19e343378369e02ab2e5775bf0314f7e9622c6c /tests | |
| parent | 1ab2d8f5ebd1127f151f5ba6538e259b94431826 (diff) | |
[QtCore] QDateTime: switch from newRow to addRow in unit tests
Instead of doing string formating first and then using QTest::newRow,
we can do both at the same time using QTest::addRow
Change-Id: Ia5c90eb705a806e37b96a1fa174a6557f91bee6d
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/auto/corelib/time/qdatetime/tst_qdatetime.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/auto/corelib/time/qdatetime/tst_qdatetime.cpp b/tests/auto/corelib/time/qdatetime/tst_qdatetime.cpp index ccb74f9e2d..71bdbe5649 100644 --- a/tests/auto/corelib/time/qdatetime/tst_qdatetime.cpp +++ b/tests/auto/corelib/time/qdatetime/tst_qdatetime.cpp @@ -2018,13 +2018,13 @@ void tst_QDateTime::operator_insert_extract_data() const QDataStream::Version dataStreamVersion = static_cast<QDataStream::Version>(version); const QByteArray vN = QByteArray::number(dataStreamVersion); const QByteArray pY = positiveYear.toString().toLatin1(); - QTest::newRow(('v' + vN + " WA => HAWAII " + pY).constData()) + QTest::addRow("v%d WA => HAWAII %d", version, 2012) << positiveYear << westernAustralia << hawaii << dataStreamVersion; - QTest::newRow(('v' + vN + " WA => WA " + pY).constData()) + QTest::addRow("v%d WA => WA %d", version, 2012) << positiveYear << westernAustralia << westernAustralia << dataStreamVersion; - QTest::newRow(('v' + vN + " HAWAII => WA " + negativeYear.toString().toLatin1()).constData()) + QTest::addRow("v%d HAWAII => WA %d", version, -2012) << negativeYear << hawaii << westernAustralia << dataStreamVersion; - QTest::newRow(('v' + vN + " HAWAII => HAWAII " + pY).constData()) + QTest::addRow("v%d HAWAII => HAWAII %d", version, 2012) << positiveYear << hawaii << hawaii << dataStreamVersion; } } |