Introduce QProcess::startCommand(QString, OpenMode)

The removal of the QProcess::start(QString, OpenMode) leads to more
porting work than anticipated. A call like

    QProcess p;
    p.start(cmdline);

must be transformed in the following cumbersome way:

    QProcess p;
    QStringList args = QProcess::splitCommand(cmdline);
    QString program = args.takeFirst();
    p.start(program, args);

This patch revives QProcess::start(QString, OpenMode) and renames it to
QProcess::startCommand. This is still source-incompatible, but the
transformation is much simpler:

    QProcess p;
    p.startCommand(cmdline);

[ChangeLog][QtCore][QProcess] Added QProcess::startCommand(QString,
OpenMode) as replacement for the removed QProcess::start(QString,
OpenMode).

Change-Id: I5499bbb39a025e115042c43a4cc63affddae585c
Reviewed-by: hjk <hjk@qt.io>

1 files changed, 15 insertions, 0 deletions

diff --git a/tests/auto/corelib/io/qprocess/tst_qprocess.cpp b/tests/auto/corelib/io/qprocess/tst_qprocess.cpp
index 317db0574c..023e254dc5 100644
--- a/tests/auto/corelib/io/qprocess/tst_qprocess.cpp
+++ b/tests/auto/corelib/io/qprocess/tst_qprocess.cpp
@@ -64,6 +64,7 @@ private slots:
     void constructing();
     void simpleStart();
     void setChildProcessModifier();
+    void startCommand();
     void startWithOpen();
     void startWithOldOpen();
     void execute();
@@ -303,6 +304,20 @@ void tst_QProcess::setChildProcessModifier()
 #endif
 }
 
+void tst_QProcess::startCommand()
+{
+    QProcess process;
+    process.startCommand("testProcessSpacesArgs/nospace foo \"b a r\" baz");
+    QVERIFY2(process.waitForStarted(), qPrintable(process.errorString()));
+    QVERIFY2(process.waitForFinished(), qPrintable(process.errorString()));
+    QCOMPARE(process.exitStatus(), QProcess::NormalExit);
+    QCOMPARE(process.exitCode(), 0);
+    QByteArray actual = process.readAll();
+    actual.remove(0, actual.indexOf('|') + 1);
+    QByteArray expected = "foo|b a r|baz";
+    QCOMPARE(actual, expected);
+}
+
 void tst_QProcess::startWithOpen()
 {
     QProcess p;