1 files changed, 13 insertions, 7 deletions
diff --git a/tests/auto/dbus/qdbustype/tst_qdbustype.cpp b/tests/auto/dbus/qdbustype/tst_qdbustype.cpp
index 2c53c4a403..63cb7d4a65 100644
--- a/tests/auto/dbus/qdbustype/tst_qdbustype.cpp
+++ b/tests/auto/dbus/qdbustype/tst_qdbustype.cpp
@@ -1,6 +1,6 @@
 // Copyright (C) 2016 The Qt Company Ltd.
 // Copyright (C) 2016 Intel Corporation.
-// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
+// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
 
 #include <QTest>
 #include <QtCore/QCoreApplication>
@@ -162,7 +162,6 @@ static void addNakedDictEntry()
 void tst_QDBusType::isValidFixedType_data()
 {
     addColumns();
-    addFixedTypes();
     addBasicTypes(Invalid);
     addVariant(Invalid);
     addInvalidSingleLetterTypes();
@@ -173,7 +172,7 @@ void tst_QDBusType::isValidFixedType()
     QFETCH(QString, data);
     QFETCH(bool, result);
     QFETCH(bool, isValid);
-    QVERIFY2(data.length() == 1, "Test is malformed, this function must test only one-letter types");
+    QVERIFY2(data.size() == 1, "Test is malformed, this function must test only one-letter types");
     QVERIFY(isValid || (!isValid && !result));
 
     int type = data.at(0).unicode();
@@ -195,7 +194,7 @@ void tst_QDBusType::isValidBasicType()
     QFETCH(QString, data);
     QFETCH(bool, result);
     QFETCH(bool, isValid);
-    QVERIFY2(data.length() == 1, "Test is malformed, this function must test only one-letter types");
+    QVERIFY2(data.size() == 1, "Test is malformed, this function must test only one-letter types");
     QVERIFY(isValid || (!isValid && !result));
 
     int type = data.at(0).unicode();
@@ -207,6 +206,7 @@ void tst_QDBusType::isValidBasicType()
 void tst_QDBusType::isValidSingleSignature_data()
 {
     addColumns();
+    QTest::newRow("empty") << "" << false;
     addSingleSignatures();
     addNakedDictEntry();
 }
@@ -223,6 +223,7 @@ void tst_QDBusType::isValidSingleSignature()
 void tst_QDBusType::isValidArray_data()
 {
     addColumns();
+    QTest::newRow("empty") << "" << false;
     addSingleSignatures();
 }
 
@@ -242,7 +243,10 @@ void tst_QDBusType::isValidArray()
 
 void tst_QDBusType::isValidSignature_data()
 {
-    isValidSingleSignature_data();
+    addColumns();
+    QTest::newRow("empty") << "" << true;
+    addSingleSignatures();
+    addNakedDictEntry();
 }
 
 void tst_QDBusType::isValidSignature()
@@ -251,8 +255,10 @@ void tst_QDBusType::isValidSignature()
     QFETCH(bool, result);
 
     data.append(data);
-    if (data.at(0).unicode())
-        QCOMPARE(bool(q_dbus_signature_validate(data.toLatin1(), 0)), result);
+    if (!data.isEmpty() && data.at(0).unicode()) {
+        // libdbus-1 API can't deal with string containing NULs
+        QCOMPARE(bool(q_dbus_signature_validate(data.toLatin1(), nullptr)), result);
+    }
     QCOMPARE(QDBusUtil::isValidSignature(data), result);
 }