summaryrefslogtreecommitdiffstats
path: root/tests/auto/gui/image/qiconhighdpi/tst_qiconhighdpi.cpp
diff options
context:
space:
mode:
Diffstat (limited to 'tests/auto/gui/image/qiconhighdpi/tst_qiconhighdpi.cpp')
-rw-r--r--tests/auto/gui/image/qiconhighdpi/tst_qiconhighdpi.cpp96
1 files changed, 67 insertions, 29 deletions
diff --git a/tests/auto/gui/image/qiconhighdpi/tst_qiconhighdpi.cpp b/tests/auto/gui/image/qiconhighdpi/tst_qiconhighdpi.cpp
index 52f38419c7..34f0132865 100644
--- a/tests/auto/gui/image/qiconhighdpi/tst_qiconhighdpi.cpp
+++ b/tests/auto/gui/image/qiconhighdpi/tst_qiconhighdpi.cpp
@@ -1,32 +1,7 @@
-/****************************************************************************
-**
-** Copyright (C) 2017 The Qt Company Ltd.
-** Contact: https://www.qt.io/licensing/
-**
-** This file is part of the test suite of the Qt Toolkit.
-**
-** $QT_BEGIN_LICENSE:GPL-EXCEPT$
-** Commercial License Usage
-** Licensees holding valid commercial Qt licenses may use this file in
-** accordance with the commercial license agreement provided with the
-** Software or, alternatively, in accordance with the terms contained in
-** a written agreement between you and The Qt Company. For licensing terms
-** and conditions see https://www.qt.io/terms-conditions. For further
-** information use the contact form at https://www.qt.io/contact-us.
-**
-** GNU General Public License Usage
-** Alternatively, this file may be used under the terms of the GNU
-** General Public License version 3 as published by the Free Software
-** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
-** included in the packaging of this file. Please review the following
-** information to ensure the GNU General Public License requirements will
-** be met: https://www.gnu.org/licenses/gpl-3.0.html.
-**
-** $QT_END_LICENSE$
-**
-****************************************************************************/
-
-#include <QtTest/QtTest>
+// Copyright (C) 2017 The Qt Company Ltd.
+// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
+
+#include <QTest>
#include <qicon.h>
class tst_QIconHighDpi : public QObject
@@ -39,7 +14,10 @@ private slots:
void initTestCase();
void fromTheme_data();
void fromTheme();
+ void addPixmap_data();
+ void addPixmap();
void ninePatch();
+ void preferUpscale();
};
tst_QIconHighDpi::tst_QIconHighDpi()
@@ -173,6 +151,49 @@ void tst_QIconHighDpi::fromTheme()
QCOMPARE(pixmap.devicePixelRatio(), expectedDpr);
}
+void tst_QIconHighDpi::addPixmap_data()
+{
+ // fromTheme() and addPixmap() test the QIconLoaderEngine and QPixmapIconEngine
+ // QIcon backend, repsectively. We want these to have identical behavior and
+ // re-use the same test data here.
+ fromTheme_data();
+}
+
+void tst_QIconHighDpi::addPixmap()
+{
+ QFETCH(int, requestedSize);
+ QFETCH(qreal, requestedDpr);
+ QFETCH(int, expectedSize);
+ QFETCH(qreal, expectedDpr);
+
+ QIcon icon;
+
+ // manual pixmap adder for full control of devicePixelRatio
+ auto addPixmapWithDpr = [&icon](const QString &path, qreal dpr) {
+ QImage image(path);
+ image.setDevicePixelRatio(dpr);
+ icon.addPixmap(QPixmap::fromImage(image));
+ };
+
+ addPixmapWithDpr(":icons/testtheme/16x16/actions/appointment-new.png", 1);
+ addPixmapWithDpr(":icons/testtheme/22x22/actions/appointment-new.png", 1);
+ addPixmapWithDpr(":icons/testtheme/22x22@2/actions/appointment-new.png", 2);
+
+ QVERIFY(icon.availableSizes().contains(QSize(16, 16)));
+ QVERIFY(icon.availableSizes().contains(QSize(22, 22)));
+
+ if (qstrcmp(QTest::currentDataTag(), "16x16,dpr=2") == 0)
+ QSKIP("broken corner case"); // expect 22x22, get 32x32
+ if (qstrcmp(QTest::currentDataTag(), "44x44,dpr=1") == 0)
+ QSKIP("broken corner case"); // expect 44x44, get 22x22
+ if (qstrcmp(QTest::currentDataTag(), "8x8,dpr=3") == 0)
+ QSKIP("broken corner case");// expect 22x22, get 24x24
+
+ const QPixmap pixmap = icon.pixmap(QSize(requestedSize, requestedSize), requestedDpr);
+ QCOMPARE(pixmap.size(), QSize(expectedSize, expectedSize));
+ QCOMPARE(pixmap.devicePixelRatio(), expectedDpr);
+}
+
void tst_QIconHighDpi::ninePatch()
{
const QIcon icon(":/icons/misc/button.9.png");
@@ -191,6 +212,23 @@ void tst_QIconHighDpi::ninePatch()
}
}
+void tst_QIconHighDpi::preferUpscale()
+{
+ QIcon icon;
+
+ // manual pixmap adder for full control of devicePixelRatio
+ auto addPixmapWithDpr = [&icon](const QString &path, qreal dpr) {
+ QImage image(path);
+ image.setDevicePixelRatio(dpr);
+ icon.addPixmap(QPixmap::fromImage(image));
+ };
+
+ addPixmapWithDpr(":/icons/testtheme/22x22/actions/appointment-new.png", 1);
+ addPixmapWithDpr(":/icons/testtheme/22x22@2/actions/appointment-new.png", 2);
+
+ QCOMPARE(icon.pixmap(QSize(22, 22), 1.25f).devicePixelRatio(), 1.25f);
+}
+
int main(int argc, char *argv[])
{
QGuiApplication app(argc, argv);