diff options
| author | Miikka Heikkinen <miikka.heikkinen@qt.io> | 2016-08-12 13:22:17 +0300 |
|---|---|---|
| committer | Miikka Heikkinen <miikka.heikkinen@qt.io> | 2016-08-12 11:14:21 +0000 |
| commit | 5820e450ad79f71f1ff0e12ec9cf06371288ea44 (patch) | |
| tree | 862ab7a7ddb30a8f250a8f0b286b44a1c665955b | |
| parent | 0c490d911ce81734d3b149a6937989c371399cc7 (diff) | |
Disconnect boxplot series from chart's dataset correctly
When a boxplot series is removed from the chart, it must disconnect
from chart's dataset. However, it only did it when animations were
enabled.
Task-number: QTBUG-55278
Change-Id: Iad89a586d16dc32299ae71aa63b3beccb4d51fdd
Reviewed-by: Mika Salmela <mika.salmela@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
| -rw-r--r-- | src/charts/boxplotchart/qboxplotseries.cpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/charts/boxplotchart/qboxplotseries.cpp b/src/charts/boxplotchart/qboxplotseries.cpp index b9d128dc..0d79707b 100644 --- a/src/charts/boxplotchart/qboxplotseries.cpp +++ b/src/charts/boxplotchart/qboxplotseries.cpp @@ -527,9 +527,10 @@ void QBoxPlotSeriesPrivate::handleSeriesRemove(QAbstractSeries *series) QBoxPlotSeries *removedSeries = static_cast<QBoxPlotSeries *>(series); - if (q == removedSeries && m_animation) { - m_animation->stopAll(); - QObject::disconnect(m_chart->d_ptr->m_dataset, 0, removedSeries->d_func(), 0); + if (q == removedSeries) { + if (m_animation) + m_animation->stopAll(); + QObject::disconnect(m_chart->d_ptr->m_dataset, 0, this, 0); } // Test if series removed is me, then don't do anything |