QtCoap: replace qSwap with member-swap where possible

qSwap() is a monster that looks for ADL overloads of swap() and also
detects the noexcept of the wrapped swap() function, so it should only
be used when the argument type is unknown. In the vast majority of
cases, the type is known to be efficiently std::swap()able or to have
a member-swap. Call either of these.

Task-number: QTBUG-97601
Pick-to: 6.3 6.2 5.15
Change-Id: Icaed67ff42bc148cb70e42d3377dea6b7eed908e
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>

1 files changed, 2 insertions, 2 deletions

diff --git a/src/coap/qcoapsecurityconfiguration.h b/src/coap/qcoapsecurityconfiguration.h
index 7dd2d9c..73b1bd9 100644
--- a/src/coap/qcoapsecurityconfiguration.h
+++ b/src/coap/qcoapsecurityconfiguration.h
@@ -57,7 +57,7 @@ public:
     QCoapPrivateKey &operator=(const QCoapPrivateKey &other);
 
     void swap(QCoapPrivateKey &other) noexcept
-    { qSwap(d, other.d); }
+    { d.swap(other.d); }
 
     bool isNull() const;
 
@@ -84,7 +84,7 @@ public:
     QCoapSecurityConfiguration &operator=(const QCoapSecurityConfiguration &other);
 
     void swap(QCoapSecurityConfiguration &other) noexcept
-    { qSwap(d, other.d); }
+    { d.swap(other.d); }
 
     void setPreSharedKeyIdentity(const QByteArray &preSharedKeyIdentity);
     QByteArray preSharedKeyIdentity() const;