diff options
| author | Thiago Macieira <thiago.macieira@intel.com> | 2021-06-22 08:50:30 -0700 |
|---|---|---|
| committer | Thiago Macieira <thiago.macieira@intel.com> | 2021-06-23 07:23:41 -0700 |
| commit | 76da83bb060ad28ee2695802a84ae4b9a17aa142 (patch) | |
| tree | 55645c7d72cd1164a36b0f4b5254e6ee01280723 | |
| parent | 3333795ff1f60d4f68ee7bdab5ef129b23121efb (diff) | |
Add missing operator=
GCC 11 says depending on it is deprecated:
bars3drenderer.cpp:237:42: required from here
qtbase/include/QtCore/../../../../../../src/qt/qt6/qtbase/src/corelib/tools/qcontainertools_impl.h:159:18: warning: implicitly-declared ‘constexpr BarRenderItem& BarRenderItem::operator=(const BarRenderItem&)’ is deprecated [-Wdeprecated-copy]
barrenderitem_p.h:51:5: note: because ‘BarRenderItem’ has user-provided ‘BarRenderItem::BarRenderItem(const BarRenderItem&)’
Note that copyable polymorphic classes are a big red flag.
Change-Id: I7246c3e7bb894e0d9521fffd168af24d8f0cd727
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Reviewed-by: Sami Varanka <sami.varanka@qt.io>
| -rw-r--r-- | src/datavisualization/data/abstractrenderitem_p.h | 1 | ||||
| -rw-r--r-- | src/datavisualization/data/barrenderitem_p.h | 2 | ||||
| -rw-r--r-- | src/datavisualization/data/scatterrenderitem_p.h | 1 |
3 files changed, 4 insertions, 0 deletions
diff --git a/src/datavisualization/data/abstractrenderitem_p.h b/src/datavisualization/data/abstractrenderitem_p.h index e95077e5..f1fcaf13 100644 --- a/src/datavisualization/data/abstractrenderitem_p.h +++ b/src/datavisualization/data/abstractrenderitem_p.h @@ -53,6 +53,7 @@ class AbstractRenderItem public: AbstractRenderItem(); AbstractRenderItem(const AbstractRenderItem &other); + AbstractRenderItem &operator=(const AbstractRenderItem &other) = default; virtual ~AbstractRenderItem(); // Position in 3D scene diff --git a/src/datavisualization/data/barrenderitem_p.h b/src/datavisualization/data/barrenderitem_p.h index b336f087..d46e0848 100644 --- a/src/datavisualization/data/barrenderitem_p.h +++ b/src/datavisualization/data/barrenderitem_p.h @@ -49,6 +49,7 @@ class BarRenderItem : public AbstractRenderItem public: BarRenderItem(); BarRenderItem(const BarRenderItem &other); + BarRenderItem &operator=(const BarRenderItem &) = default; virtual ~BarRenderItem(); // Position relative to data window (for bar label generation) @@ -76,6 +77,7 @@ class BarRenderSliceItem : public BarRenderItem public: BarRenderSliceItem(); BarRenderSliceItem(const BarRenderSliceItem &other); + BarRenderSliceItem &operator=(const BarRenderSliceItem &other) = default; virtual ~BarRenderSliceItem(); void setItem(const BarRenderItem &renderItem); diff --git a/src/datavisualization/data/scatterrenderitem_p.h b/src/datavisualization/data/scatterrenderitem_p.h index d36a01bf..5810c8ba 100644 --- a/src/datavisualization/data/scatterrenderitem_p.h +++ b/src/datavisualization/data/scatterrenderitem_p.h @@ -49,6 +49,7 @@ class ScatterRenderItem : public AbstractRenderItem public: ScatterRenderItem(); ScatterRenderItem(const ScatterRenderItem &other); + ScatterRenderItem &operator=(const ScatterRenderItem &) = default; virtual ~ScatterRenderItem(); inline const QVector3D &position() const { return m_position; } |