diff options
| author | Marc Mutz <marc.mutz@qt.io> | 2023-10-13 12:07:45 +0200 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@qt.io> | 2023-10-13 12:38:06 +0200 |
| commit | 92d4eacaa5137bbd1cf67213a29dc794a2efea8a (patch) | |
| tree | 32b2442ad89a74a1d151880354ee75b813c032f6 | |
| parent | 49e02b37ade08785fb4bf6a14ec0d71ff5d4dbf7 (diff) | |
Include what you need: <QPointer>
All these TUs relied on transitive includes of qpointer.h, maybe to a
large extent via qevent.h, though, given that qevent.h is more or less
the only public QtBase header that includes qpointer.h, something else
seems to be at play here.
Said qevent.h actually needs QPointer in-name-only, so a forward
declaration would suffice. Prepare for qevent.h dropping the include.
The algorithm I used was:
If the TU mentions 'passiveGrabbers', the name of the QEvent function
that returns QPointers, and the TU doesn't have qpointer.h included
explicitly, include it. That may produce False Positives, but better
safe than sorry. Otherwise, in src/, add an include to all source and
header files which mention QPointer. Exception: if foo.h of a foo.cpp
already includes it, don't include again.
Task-number: QTBUG-117670
Change-Id: I3e240ca20cb4d0f37a2267a70fa5a672264b4c52
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
| -rw-r--r-- | src/datavisualization/engine/abstract3drenderer_p.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/datavisualization/engine/abstract3drenderer_p.h b/src/datavisualization/engine/abstract3drenderer_p.h index 401665f9..560e6d2e 100644 --- a/src/datavisualization/engine/abstract3drenderer_p.h +++ b/src/datavisualization/engine/abstract3drenderer_p.h @@ -24,6 +24,8 @@ #include "seriesrendercache_p.h" #include "customrenderitem_p.h" +#include <QtCore/qpointer.h> + QT_FORWARD_DECLARE_CLASS(QOffscreenSurface) QT_BEGIN_NAMESPACE |