summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVolker Hilsheimer <volker.hilsheimer@qt.io>2023-08-21 12:14:17 +0200
committerVolker Hilsheimer <volker.hilsheimer@qt.io>2023-08-22 11:57:44 +0200
commita127aece4021a2c760d496d63849c63187b0219c (patch)
tree9d40c57006eace10ae7d74683b1af7fd1c720c97
parenta84bf68892e93450e8c4ab1a6b90ae843dc6af35 (diff)
Replace foreach with ranged for loop
Store the list of graphs in a const list and use ranged for. Remove Q_FOREACH-whitelisting of source file. Amends a84bf68892e93450e8c4ab1a6b90ae843dc6af35. Pick-to: 6.6 Change-Id: I95b624e15ee7dd242c02812520615c3f778b21dc Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io> Reviewed-by: Sami Varanka <sami.varanka@qt.io>
-rw-r--r--src/datavisualizationqml/abstractdeclarative.cpp6
1 files changed, 2 insertions, 4 deletions
diff --git a/src/datavisualizationqml/abstractdeclarative.cpp b/src/datavisualizationqml/abstractdeclarative.cpp
index b4e01003..af19d46f 100644
--- a/src/datavisualizationqml/abstractdeclarative.cpp
+++ b/src/datavisualizationqml/abstractdeclarative.cpp
@@ -1,8 +1,6 @@
// Copyright (C) 2016 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
-#undef QT_NO_FOREACH // this file contains unported legacy Q_FOREACH uses
-
#include "abstractdeclarative_p.h"
#include "declarativetheme_p.h"
#include "declarativerendernode_p.h"
@@ -649,8 +647,8 @@ void AbstractDeclarative::checkWindowList(QQuickWindow *window)
}
QList<QQuickWindow *> windowList;
-
- foreach (AbstractDeclarative *graph, graphWindowList.keys()) {
+ const auto graphs = graphWindowList.keys();
+ for (AbstractDeclarative *graph : graphs) {
if (graph->m_renderMode == RenderDirectToBackground
|| graph->m_renderMode == RenderDirectToBackground_NoClear) {
windowList.append(graphWindowList.value(graph));