diff options
author | Miikka Heikkinen <miikka.heikkinen@digia.com> | 2013-12-03 10:46:54 +0200 |
---|---|---|
committer | Miikka Heikkinen <miikka.heikkinen@digia.com> | 2013-12-03 11:37:24 +0200 |
commit | f61a34e357a3fdbc78c344ee6134fc87113fb33a (patch) | |
tree | 7ebff5b00bbfcb3094d9f7fea01ceef843e492a5 /src/datavisualization/data/qbardataproxy.h | |
parent | 9549c09d4cfee485c31f54360a32d100d06a2095 (diff) |
Miscellaneous api cleanup
Task-number: QTRD-2665
Change-Id: I3ed82721603e1b72b4b1543f197d1eabb8743bb7
Reviewed-by: Tomi Korpipää <tomi.korpipaa@digia.com>
Diffstat (limited to 'src/datavisualization/data/qbardataproxy.h')
-rw-r--r-- | src/datavisualization/data/qbardataproxy.h | 28 |
1 files changed, 1 insertions, 27 deletions
diff --git a/src/datavisualization/data/qbardataproxy.h b/src/datavisualization/data/qbardataproxy.h index e97e6a85..accd7460 100644 --- a/src/datavisualization/data/qbardataproxy.h +++ b/src/datavisualization/data/qbardataproxy.h @@ -44,15 +44,6 @@ public: explicit QBarDataProxy(QObject *parent = 0); virtual ~QBarDataProxy(); - // TODO: Replace first part of class description in docs with this once all TODOs are done: - /* - * QBarDataProxy is optimized for adding, inserting, and removing rows of data. - * Adding a column essentially means modifying every row, which is comparatively very inefficient. - * Proxy is also optimized to use cases where the only defining characteristic of an individual - * bar is its value. Modifying other data that might be added in the future such as color of - * individual bar requires allocating additional data object for the bar. - */ - QBar3DSeries *series(); int rowCount() const; @@ -75,31 +66,19 @@ public: void setRows(int rowIndex, const QBarDataArray &rows); void setRows(int rowIndex, const QBarDataArray &rows, const QStringList &labels); - // Setting a column is comparatively inefficient as it changes all rows. - // Can resize rows that are shorter than columnIndex. - // TODO void setColumn(int columnIndex, const QBarDataRow &column); - // TODO void setColumns(int columnIndex, const QBarDataArray &columns); - void setItem(int rowIndex, int columnIndex, const QBarDataItem &item); - // Change block of items - // TODO setItems(int rowIndex, int columnIndex, QBarDataArray *items); int addRow(QBarDataRow *row); int addRow(QBarDataRow *row, const QString &label); int addRows(const QBarDataArray &rows); int addRows(const QBarDataArray &rows, const QStringList &labels); - // TODO int addColumn(const QBarDataRow &column); // returns the index of the added column - // TODO int addColumns(const QBarDataArray &columns); // returns the index of the first added column void insertRow(int rowIndex, QBarDataRow *row); void insertRow(int rowIndex, QBarDataRow *row, const QString &label); void insertRows(int rowIndex, const QBarDataArray &rows); void insertRows(int rowIndex, const QBarDataArray &rows, const QStringList &labels); - // TODO void insertColumn(int columnIndex, const QBarDataRow &column); - // TODO void insertColumns(int columnIndex, const QBarDataArray &columns); void removeRows(int rowIndex, int removeCount, bool removeLabels = true); - // TODO void removeColumns(int columnIndex, int removeCount); signals: void arrayReset(); @@ -107,12 +86,7 @@ signals: void rowsChanged(int startIndex, int count); void rowsRemoved(int startIndex, int count); void rowsInserted(int startIndex, int count); - // TODO void columnsChanged(int startIndex, int count); - // TODO void columnsAdded(int startIndex, int count); - // TODO void columnsRemoved(int startIndex, int count); - // TODO void columnsInserted(int startIndex, int count); - void itemChanged(int rowIndex, int columnIndex); // TODO remove once itemsChanged is added? - // TODO void itemsChanged(int rowIndex, int columnIndex, int rowCount, int columnCount); + void itemChanged(int rowIndex, int columnIndex); void rowLabelsChanged(); void columnLabelsChanged(); |