summaryrefslogtreecommitdiffstats
path: root/src/datavisualization/CMakeLists.txt
Commit message (Collapse)AuthorAgeFilesLines
* Mark the whole repo with QT_NO_CONTEXTLESS_CONNECTAhmad Samir2023-08-241-2/+0
| | | | | | | | | | By adding it to the default build flags via .cmake.conf. This amends commit 69404b3f0d4e650c0b21ed07862be49b51c99300. Task-number: QTBUG-116296 Change-Id: I8e80246dc2283b369f31971aaceeb907b0cfdfd0 Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
* Mark the module as free of Q_FOREACH, except where it isn'tMarc Mutz2023-08-181-0/+14
| | | | | | | | | | | | | | | | | | | | | | The density of Q_FOREACH uses is high here, too high for this author, unfamiliar with this module, to tackle in a short amount of time. But they're concentrated in just a few TUs, so pick a different strategy: Mark the whole module with QT_NO_FOREACH, to prevent new uses from creeping in, and whitelist the affected TUs by #undef'ing QT_NO_FOREACH locally, at the top of each file. For TUs that are part of a larger executable, this requires these files to be compiled separately, so add them to NO_PCH_SOURCES (which implies NO_UNITY_BUILD_SOURCES, too). Created QTBUG-115807 to keep track of this. Ported one that was trivial and where whitelisting of the file with a single Q_FOREACH would have been more work than directly fixing it. Task-number: QTBUG-115807 Change-Id: I2fa6c740e35039baf34115af7d69d6c420e4de10 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
* Build with QT_NO_CONTEXTLESS_CONNECTAhmad Samir2023-07-311-0/+2
| | | | | | | | | | | | | This disables the 3-arg QObject::connect() overload: QObject::connect(sender, signal, functor) For details see: https://lists.qt-project.org/pipermail/development/2023-July/044141.html No changes required. Change-Id: I831233f02d8da4e929d5174aa98946007103a0ec Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
* Exclude a few source files from unity buildAmir Masoud Abdol2023-04-181-0/+11
| | | | | | | | | | | | MinGW triggers `-Werror=maybe-uninitialized` while proper checks are in place and d_ptr is initialized in operator=(). The copy constructor can probably be implemented differently, but for now, excluding the files allows us to continue testing the unity build. Pick-to: 6.5 Task-number: QTBUG-109394 Change-Id: Ibb2a101a4fe5a6833903a28887077f0bde5573f8 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Remove dependency on Qml target for the non-qml moduleAlexandru Croitor2023-04-171-3/+0
| | | | | | | | Pick-to: 6.5 Fixes: QTBUG-112813 Change-Id: Ib8d479278657b0741e5e325821c6f1432725005e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
* Rename shader and mesh resource filesTomi Korpipaa2022-10-111-2/+2
| | | | | | | | | | | | | | | WASM gets a conflict with Multimedia if the resource file is named just shaders. Doing the same for meshes to avoid future conflicts with some other modules. Pick-to: 6.4 Fixes: QTBUG-107505 Change-Id: I9107f270d8679d1a50ec8127d15cb0c50856eb7c Reviewed-by: Kwanghyo Park <kwanghyo.park@qt.io> Reviewed-by: Sami Varanka <sami.varanka@qt.io> Reviewed-by: Tuomo Pelkonen <tuomo.pelkonen@qt.io> Reviewed-by: Dilek Akcay <dilek.akcay@qt.io> Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
* Change the license of all CMakeLists.txt and *.cmake files to BSDLucie Gérard2022-08-231-1/+1
| | | | | | | Task-number: QTBUG-105718 Change-Id: Id14ba04aaa0724ea734339b96437853065874e3a Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Add license headers to cmake filesLucie Gérard2022-08-031-0/+3
| | | | | | | | | | | | CMakeLists.txt and .cmake files of significant size (more than 2 lines according to our check in tst_license.pl) now have the copyright and license header. Existing copyright statements remain intact Task-number: QTBUG-88621 Change-Id: I829aeda2bda017b7d5bf39795b79dbaee143cb60 Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Fix layering violation involving AbstractDeclarativeMarc Mutz2022-07-061-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When trying an ubsan build of qtdatavis3d, I get: abstract3dcontroller.cpp.o: undefined reference to `typeinfo for AbstractDeclarative' Turns out that AbstractDeclarative is defined in DataVisualizationQml, a separate library, which depends on DataVisualization. It seems this worked because Abstract3DController only used inline members of AbstractDeclarative, so a normal build doesn't need the class exported, even though it's curious that inline isReady() calls exported QQuickItem::isComponentLoaded() and the linker didn't complain. But an UBSan build requires the type_info, which isn't available, because the class wasn't exported, and cannot be made available because of the layering violation. To fix, Extract Superclass AbstractDeclarativeInterface that provides only the required isReady() function, but lives in DataVisualization, and have the real AbstractDeclarative inherit it. As a drive-by, make isReady() const. Pick-to: 6.4 6.3 6.2 Fixes: QTBUG-104714 Change-Id: I0eb718746355f409a4105e2d53e79b7003fd8b22 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Sona Kurazyan <sona.kurazyan@qt.io>
* Migrate to autogenerated cpp exportsAlexey Edelev2021-09-271-0/+1
| | | | | | | | | | | | Replace the hardcoded cpp exports with a generated one where it's applicable. Change the cpp export macro name to the autogenerated one. Task-number: QTBUG-90492 Change-Id: Iff6fbff102297feffd443b8b6fef61f5e8f135e5 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io> Reviewed-by: Sami Varanka <sami.varanka@qt.io> Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
* Modernize and update to latest CMake APIUlf Hermann2021-06-111-1/+1
| | | | | | | | | | Use declarative registration for QML types, and separate the backing library from the plugin. Also, bump the revision numbers to account for Qt6 and drop the "2" from the source directory name. Change-Id: Ib48f90ad32a3624e7c31f1d2af9fcd92f069ee7f Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io> Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
* Use fixed qt_add_resource BASE argumentJoerg Bornemann2021-05-221-68/+68
| | | | | | | | Pick-to: 6.1 Task-number: QTBUG-86726 Change-Id: I8372086c40043a6bd1d306b6bfb711e96ddc7cb7 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Fix Gradients don't showSami Varanka2021-05-181-0/+1
| | | | | | | | | | | | | Added pointer to graph in Abstract3DController. Controller can use that pointer to check whether the graph is ready when receiving a themetypeChanged signal. Added manual test for gradients. Pick-to: 6.1 Fixes: QTBUG-93506 Change-Id: I13df962b807feb615e3267f580ef57dd62a0b058 Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
* Add CMake buildTuomo Pelkonen2021-01-271-0/+402
Task-number: QTBUG-89299 Change-Id: I5becbf39605e566c3d32cb5e210d974df9de27da Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io> Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>