diff options
| author | Shawn Rutledge <shawn.rutledge@qt.io> | 2022-09-07 17:58:08 +0200 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2022-09-11 15:48:42 +0000 |
| commit | c5e7d26580377175cb9129d575b9c24eea1c6d71 (patch) | |
| tree | 5d32cbcaeb0dd52a6ab9007295945c22d54bd0da | |
| parent | 21aac7612477ada4c4b360681541312a98cfacfc (diff) | |
Avoid dangling pointers in handler for QQuickPixmapReply::finished
Fixes: QTBUG-106357
Change-Id: I78156b403618c88da26d381be7a6e777a6d22f87
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
(cherry picked from commit 88aff6f851a70e5bb5082b04943a5c8ddf026d44)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
| -rw-r--r-- | src/quick/util/qquickpixmapcache.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/quick/util/qquickpixmapcache.cpp b/src/quick/util/qquickpixmapcache.cpp index 51be6f8e51..a6e45d769d 100644 --- a/src/quick/util/qquickpixmapcache.cpp +++ b/src/quick/util/qquickpixmapcache.cpp @@ -1747,8 +1747,7 @@ void QQuickPixmap::loadImageFromDevice(QQmlEngine *engine, QIODevice *device, co QQuickPixmapReader::readerMutex.lock(); d->reply = QQuickPixmapReader::instance(engine)->getImage(d); if (oldD) { - QObject::connect(d->reply, &QQuickPixmapReply::finished, [oldD, this]() { - oldD->declarativePixmaps.remove(this); + QObject::connect(d->reply, &QQuickPixmapReply::finished, [oldD]() { oldD->release(); }); } |