Add --warnings-are-errors option to qmlcachegen

[ChangeLog][qmlcachegen] Added the --warnings-are-errors option that
treats warnings as errors when generating C++ code.

Like gcc's -Werror, this option is useful when aiming at warning-free
QML code. Add it to the QT_QMLCACHEGEN_ARGUMENTS target property to
error out once warnings have been encountered.

Change-Id: If72875b33052b37642b18fa192a1344c347990d8
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>

1 files changed, 8 insertions, 1 deletions

diff --git a/tools/qmlcachegen/qmlcachegen.cpp b/tools/qmlcachegen/qmlcachegen.cpp
index da30307466..bcd6a7387f 100644
--- a/tools/qmlcachegen/qmlcachegen.cpp
+++ b/tools/qmlcachegen/qmlcachegen.cpp
@@ -91,6 +91,9 @@ int main(int argc, char **argv)
     parser.addOption(onlyBytecode);
     QCommandLineOption verboseOption("verbose"_L1, QCoreApplication::translate("main", "Output compile warnings"));
     parser.addOption(verboseOption);
+    QCommandLineOption warningsAreErrorsOption("warnings-are-errors"_L1, QCoreApplication::translate("main", "Treat warnings as errors"));
+    parser.addOption(warningsAreErrorsOption);
+
     QCommandLineOption validateBasicBlocksOption("validate-basic-blocks"_L1, QCoreApplication::translate("main", "Performs checks on the basic blocks of a function compiled ahead of time to validate its structure and coherence"));
     parser.addOption(validateBasicBlocksOption);
 
@@ -247,7 +250,7 @@ int main(int argc, char **argv)
             logger.setCategoryIgnored(qmlCompiler, false);
             logger.setCategoryFatal(qmlCompiler, true);
 
-            if (!parser.isSet(verboseOption))
+            if (!parser.isSet(verboseOption) && !parser.isSet(warningsAreErrorsOption))
                 logger.setSilent(true);
 
             QQmlJSAotCompiler cppCodeGen(
@@ -268,6 +271,8 @@ int main(int argc, char **argv)
                 logger.log("Type warnings occurred while compiling file:"_L1,
                            qmlImport, QQmlJS::SourceLocation());
                 logger.processMessages(warnings, qmlImport);
+                if (parser.isSet(warningsAreErrorsOption))
+                    return EXIT_FAILURE;
             }
         }
     } else if (inputFile.endsWith(".js"_L1) || inputFile.endsWith(".mjs"_L1)) {
@@ -278,6 +283,8 @@ int main(int argc, char **argv)
         }
     } else {
         fprintf(stderr, "Ignoring %s input file as it is not QML source code - maybe remove from QML_FILES?\n", qPrintable(inputFile));
+        if (parser.isSet(warningsAreErrorsOption))
+            return EXIT_FAILURE;
     }
 
     return EXIT_SUCCESS;