diff options
| author | Ulf Hermann <ulf.hermann@qt.io> | 2020-06-26 15:44:23 +0200 |
|---|---|---|
| committer | Ulf Hermann <ulf.hermann@qt.io> | 2020-06-30 09:39:55 +0000 |
| commit | 41890402db086f4c61e052cef7659eb6b003dc77 (patch) | |
| tree | d917de227629d6a0ea55f9e3c0897c457fe55bdd | |
| parent | 8bd6342639721b7db08acf554c6bcd3e7ab04cb6 (diff) | |
Revive QTQUICK_COMPILER_SKIPPED_RESOURCES
There are valid reasons not to compile some resources with qmlcachegen.
Pick-to: 5.15
Fixes: QTBUG-85243
Change-Id: I9a1233864ed5dda0c264e61db596a9d8c80ea1f3
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
| -rw-r--r-- | tests/auto/qml/qmlcachegen/data/skip.qrc | 5 | ||||
| -rw-r--r-- | tests/auto/qml/qmlcachegen/qmlcachegen.pro | 5 | ||||
| -rw-r--r-- | tests/auto/qml/qmlcachegen/tst_qmlcachegen.cpp | 14 | ||||
| -rw-r--r-- | tools/qmlcachegen/qtquickcompiler.prf | 12 |
4 files changed, 34 insertions, 2 deletions
diff --git a/tests/auto/qml/qmlcachegen/data/skip.qrc b/tests/auto/qml/qmlcachegen/data/skip.qrc new file mode 100644 index 0000000000..391e4f7508 --- /dev/null +++ b/tests/auto/qml/qmlcachegen/data/skip.qrc @@ -0,0 +1,5 @@ +<RCC> + <qresource prefix="/not/"> + <file alias="Skip.qml">Retain.qml</file> + </qresource> +</RCC> diff --git a/tests/auto/qml/qmlcachegen/qmlcachegen.pro b/tests/auto/qml/qmlcachegen/qmlcachegen.pro index 452bd7d04a..dc1c4dc4dc 100644 --- a/tests/auto/qml/qmlcachegen/qmlcachegen.pro +++ b/tests/auto/qml/qmlcachegen/qmlcachegen.pro @@ -28,11 +28,12 @@ workerscripts_test.prefix = /workerscripts RESOURCES += \ workerscripts_test \ trickypaths.qrc \ - data/retain.qrc + data/retain.qrc \ + data/skip.qrc # QTBUG-46375 !win32: RESOURCES += trickypaths_umlaut.qrc -QTQUICK_COMPILER_RETAINED_RESOURCES += retain.qrc +QTQUICK_COMPILER_SKIPPED_RESOURCES += data/skip.qrc QT += core-private qml-private testlib diff --git a/tests/auto/qml/qmlcachegen/tst_qmlcachegen.cpp b/tests/auto/qml/qmlcachegen/tst_qmlcachegen.cpp index c6ec2eb780..652942b243 100644 --- a/tests/auto/qml/qmlcachegen/tst_qmlcachegen.cpp +++ b/tests/auto/qml/qmlcachegen/tst_qmlcachegen.cpp @@ -56,6 +56,7 @@ private slots: void functionExpressions(); void versionChecksForAheadOfTimeUnits(); void retainedResources(); + void skippedResources(); void workerScripts(); @@ -411,6 +412,19 @@ void tst_qmlcachegen::retainedResources() QVERIFY(file.readAll().startsWith("import QtQml 2.0")); } +void tst_qmlcachegen::skippedResources() +{ + QFile file(":/not/Skip.qml"); + QVERIFY(file.open(QIODevice::ReadOnly)); + QVERIFY(file.readAll().startsWith("import QtQml 2.0")); + + QQmlMetaType::CachedUnitLookupError error = QQmlMetaType::CachedUnitLookupError::NoError; + const QQmlPrivate::CachedQmlUnit *unit = QQmlMetaType::findCachedCompilationUnit( + QUrl("qrc:/not/Skip.qml"), &error); + QCOMPARE(unit, nullptr); + QCOMPARE(error, QQmlMetaType::CachedUnitLookupError::NoUnitFound); +} + void tst_qmlcachegen::workerScripts() { QVERIFY(QFile::exists(":/workerscripts/data/worker.js")); diff --git a/tools/qmlcachegen/qtquickcompiler.prf b/tools/qmlcachegen/qtquickcompiler.prf index 2e8e3f91b4..d1b7a5aad5 100644 --- a/tools/qmlcachegen/qtquickcompiler.prf +++ b/tools/qmlcachegen/qtquickcompiler.prf @@ -25,6 +25,13 @@ defineReplace(qmlCacheResourceFileOutputName) { return($${name}) } +defineTest(qtQuickSkippedResourceFile) { + for(skippedRes, QTQUICK_COMPILER_SKIPPED_RESOURCES) { + equals(1, $$skippedRes): return(true) + } + return(false) +} + # Flatten RESOURCES that may contain individual files or objects load(resources_functions) qtFlattenResources() @@ -34,6 +41,11 @@ NEWRESOURCES = QMLCACHE_RESOURCE_FILES = for(res, RESOURCES) { + qtQuickSkippedResourceFile($$res) { + NEWRESOURCES += $$res + next() + } + absRes = $$absolute_path($$res, $$_PRO_FILE_PWD_) rccContents = $$system($$QMAKE_RCC_DEP -list $$system_quote($$absRes),lines) contains(rccContents,.*\\.js$)|contains(rccContents,.*\\.qml$)|contains(rccContents,.*\\.mjs$) { |