diff options
author | Shawn Rutledge <shawn.rutledge@qt.io> | 2022-01-21 10:52:48 +0100 |
---|---|---|
committer | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2022-01-23 17:41:18 +0000 |
commit | 5d2ffc03f89d092f46ae14e958bedf9fc441b7ec (patch) | |
tree | 79ceaec0a8a3a39a484da44250caa28fe72689fa | |
parent | 3fdd64e6e75ebfec82b6824801ebf11b6fd3aac3 (diff) |
Skip the shapes tests on offscreen platform
Replace QEXPECT_FAIL with QSKIP so that grabWindow can be fixed in the
offscreen plugin without XPASS-failing tests in qtdeclarative.
Task-number: QTBUG-99962
Pick-to: 6.3
Change-Id: I470061a324c963e09b9ebcb48daabdf8d960ff90
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
-rw-r--r-- | tests/auto/quick/qquickshape/tst_qquickshape.cpp | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/tests/auto/quick/qquickshape/tst_qquickshape.cpp b/tests/auto/quick/qquickshape/tst_qquickshape.cpp index 14f280e354..d72a3d265e 100644 --- a/tests/auto/quick/qquickshape/tst_qquickshape.cpp +++ b/tests/auto/quick/qquickshape/tst_qquickshape.cpp @@ -284,7 +284,7 @@ void tst_QQuickShape::render() if ((QGuiApplication::platformName() == QLatin1String("offscreen")) || (QGuiApplication::platformName() == QLatin1String("minimal"))) - QEXPECT_FAIL("", "Failure due to grabWindow not functional on offscreen/minimal platforms", Abort); + QSKIP("Skipping due to grabWindow not functional on offscreen/minimal platforms"); QImage img = window->grabWindow(); QVERIFY(!img.isNull()); @@ -308,7 +308,7 @@ void tst_QQuickShape::renderWithMultipleSp() if ((QGuiApplication::platformName() == QLatin1String("offscreen")) || (QGuiApplication::platformName() == QLatin1String("minimal"))) - QEXPECT_FAIL("", "Failure due to grabWindow not functional on offscreen/minimal platforms", Abort); + QSKIP("Skipping due to grabWindow not functional on offscreen/minimal platforms"); QImage img = window->grabWindow(); QVERIFY(!img.isNull()); @@ -332,7 +332,7 @@ void tst_QQuickShape::radialGrad() if ((QGuiApplication::platformName() == QLatin1String("offscreen")) || (QGuiApplication::platformName() == QLatin1String("minimal"))) - QEXPECT_FAIL("", "Failure due to grabWindow not functional on offscreen/minimal platforms", Abort); + QSKIP("Skipping due to grabWindow not functional on offscreen/minimal platforms"); QImage img = window->grabWindow(); QVERIFY(!img.isNull()); @@ -356,7 +356,7 @@ void tst_QQuickShape::conicalGrad() if ((QGuiApplication::platformName() == QLatin1String("offscreen")) || (QGuiApplication::platformName() == QLatin1String("minimal"))) - QEXPECT_FAIL("", "Failure due to grabWindow not functional on offscreen/minimal platforms", Abort); + QSKIP("Skipping due to grabWindow not functional on offscreen/minimal platforms"); QImage img = window->grabWindow(); QVERIFY(!img.isNull()); @@ -380,7 +380,7 @@ void tst_QQuickShape::renderPolyline() if ((QGuiApplication::platformName() == QLatin1String("offscreen")) || (QGuiApplication::platformName() == QLatin1String("minimal"))) - QEXPECT_FAIL("", "Failure due to grabWindow not functional on offscreen/minimal platforms", Abort); + QSKIP("Skipping due to grabWindow not functional on offscreen/minimal platforms"); QImage img = window->grabWindow(); QVERIFY(!img.isNull()); @@ -409,7 +409,7 @@ void tst_QQuickShape::renderMultiline() if ((QGuiApplication::platformName() == QLatin1String("offscreen")) || (QGuiApplication::platformName() == QLatin1String("minimal"))) - QEXPECT_FAIL("", "Failure due to grabWindow not functional on offscreen/minimal platforms", Abort); + QSKIP("Skipping due to grabWindow not functional on offscreen/minimal platforms"); QImage img = window->grabWindow(); QVERIFY(!img.isNull()); @@ -475,7 +475,7 @@ void tst_QQuickShape::polylineDataTypes() if ((QGuiApplication::platformName() == QLatin1String("offscreen")) || (QGuiApplication::platformName() == QLatin1String("minimal"))) - QEXPECT_FAIL("", "Failure due to grabWindow not functional on offscreen/minimal platforms", Abort); + QSKIP("Skipping due to grabWindow not functional on offscreen/minimal platforms"); QImage img = window->grabWindow(); QVERIFY(!img.isNull()); @@ -626,7 +626,7 @@ void tst_QQuickShape::multilineDataTypes() if ((QGuiApplication::platformName() == QLatin1String("offscreen")) || (QGuiApplication::platformName() == QLatin1String("minimal"))) - QEXPECT_FAIL("", "Failure due to grabWindow not functional on offscreen/minimal platforms", Abort); + QSKIP("Skipping due to grabWindow not functional on offscreen/minimal platforms"); QImage img = window->grabWindow(); QVERIFY(!img.isNull()); @@ -673,8 +673,8 @@ void tst_QQuickShape::multilineStronglyTyped() provider->setPaths(m_lowPolyLogo); if ((QGuiApplication::platformName() == QLatin1String("offscreen")) - || (QGuiApplication::platformName() == QLatin1String("minimal"))) - QEXPECT_FAIL("", "Failure due to grabWindow not functional on offscreen/minimal platforms", Abort); + || (QGuiApplication::platformName() == QLatin1String("minimal"))) + QSKIP("Skipping due to grabWindow not functional on offscreen/minimal platforms"); QImage img = window->grabWindow(); QVERIFY(!img.isNull()); |