diff options
| author | Marc Mutz <marc.mutz@qt.io> | 2023-06-23 16:58:04 +0200 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@qt.io> | 2023-06-23 23:54:31 +0200 |
| commit | 70f9fed9c3cf96fa4a6a8f67c626acc71b600295 (patch) | |
| tree | d44562ee5f132ab0bda37c622ba9f6ad0cb562e7 | |
| parent | a05b9899a4d2db5984e248bff0eed1788e373ae1 (diff) | |
DocumentImpl: use override instead of virtual
Virtual functions should have exactly one of virtual, override or
final: virtual is for new virtual functions, override and final for
overrides.
DocumentImpl has a virtual dtor due to NodeImpl's being virtual,
therefore ovrride is apt.
Pick-to: 6.6 6.5
Change-Id: Ib5395b92133b403deb9342b4c3f35d638df94561
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
| -rw-r--r-- | src/qml/qml/qqmlxmlhttprequest.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/qml/qml/qqmlxmlhttprequest.cpp b/src/qml/qml/qqmlxmlhttprequest.cpp index 3d0a87ffcb..979cc76e59 100644 --- a/src/qml/qml/qqmlxmlhttprequest.cpp +++ b/src/qml/qml/qqmlxmlhttprequest.cpp @@ -120,7 +120,7 @@ class DocumentImpl : public QQmlRefCount, public NodeImpl { public: DocumentImpl() : root(nullptr) { type = Document; } - virtual ~DocumentImpl() { + ~DocumentImpl() override { delete root; } |