diff options
| author | Jan Arve Sæther <jan-arve.saether@qt.io> | 2020-03-02 10:46:58 +0100 |
|---|---|---|
| committer | Jan Arve Sæther <jan-arve.saether@qt.io> | 2020-03-26 16:39:02 +0100 |
| commit | c64013079908e0d6ce90d565fbeaed7816c236ff (patch) | |
| tree | 5bca4e90b866ccad8ca844e1a1bde55ac4f0978f | |
| parent | a5b4d3dbab70c8e0cc57e895007fc4a798e129c7 (diff) | |
Remove comments about renaming and removing properties for Qt6
For the record, my argument for not acting upon these comments was that
they seems to be missing a key issue:
OrientationSensor does not offer a superset of the features of
QQuickScreen::orientation. Therefore, it cannot just replace
QQuickScreen::orientation: An OrientationReading is the output from the
sensor itself regardless of any settings that was made in the OS to for
instance lock the UI to landscape only. And this seems to be the point
of the QScreen::orientation: It's supposed to be the "virtual/locked"
orientation we get when we ask the OS (which might not reflect the true
physical orientation, since it might be overridden by the OS due to e.g.
landscape locking).
The original author agreed with this argument, and agreed that the
comments can just be removed.
Change-Id: I2df0ae9debc6b6177f0e4ee6efb60c03da726e15
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
| -rw-r--r-- | src/quick/items/qquickscreen_p.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/quick/items/qquickscreen_p.h b/src/quick/items/qquickscreen_p.h index b4266d78c7..9a2a9eaecf 100644 --- a/src/quick/items/qquickscreen_p.h +++ b/src/quick/items/qquickscreen_p.h @@ -78,9 +78,7 @@ class Q_QUICK_PRIVATE_EXPORT QQuickScreenInfo : public QObject Q_PROPERTY(qreal logicalPixelDensity READ logicalPixelDensity NOTIFY logicalPixelDensityChanged) Q_PROPERTY(qreal pixelDensity READ pixelDensity NOTIFY pixelDensityChanged) Q_PROPERTY(qreal devicePixelRatio READ devicePixelRatio NOTIFY devicePixelRatioChanged) - // TODO Qt 6 Rename primaryOrientation to orientation Q_PROPERTY(Qt::ScreenOrientation primaryOrientation READ primaryOrientation NOTIFY primaryOrientationChanged) - // TODO Qt 6 Remove this orientation -> incomplete device orientation -> better use OrientationSensor Q_PROPERTY(Qt::ScreenOrientation orientation READ orientation NOTIFY orientationChanged) Q_PROPERTY(int virtualX READ virtualX NOTIFY virtualXChanged REVISION 3) |