tst_qmlproperty: Fix access of dangling pointer

    const char *name = propertyName.toLatin1().constData();

big no-no... valgrind was quite angry:

==49215== Invalid read of size 1
==49215==    at 0x4C304F2: strlen (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==49215==    by 0x5E991C5: QMetaObject::indexOfProperty(char const*) const (qmetaobject.cpp:1007)
==49215==    by 0x5ED1273: QObject::property(char const*) const (qobject.cpp:3912)
==49215==    by 0x42AAA5: tst_qqmlproperty::floatToStringPrecision() (tst_qqmlproperty.cpp:2082)
==49215==    by 0x42BB37: tst_qqmlproperty::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (tst_qqmlproperty.moc:533)
==49215==    by 0x5E9B32D: QMetaMethod::invoke(QObject*, Qt::ConnectionType, QGenericReturnArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) const (qmetaobject.cpp:2237)
==49215==    by 0x40434FB: QMetaMethod::invoke(QObject*, Qt::ConnectionType, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) const (qmetaobject.h:123)
==49215==    by 0x403C39C: QTest::TestMethods::invokeTestOnData(int) const (qtestcase.cpp:838)
==49215==    by 0x403CE98: QTest::TestMethods::invokeTest(int, char const*, QTest::WatchDog*) const (qtestcase.cpp:1019)
==49215==    by 0x403DF45: QTest::TestMethods::invokeTests(QObject*) const (qtestcase.cpp:1321)
==49215==    by 0x403EA9F: QTest::qExec(QObject*, int, char**) (qtestcase.cpp:1733)
==49215==    by 0x42B219: main (tst_qqmlproperty.cpp:2104)
==49215==  Address 0x155bb3d0 is 16 bytes inside a block of size 18 free'd
==49215==    at 0x4C2E38B: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==49215==    by 0x5C3F9FC: QArrayData::deallocate(QArrayData*, unsigned long, unsigned long) (qarraydata.cpp:215)
==49215==    by 0x42F2CB: QTypedArrayData<char>::deallocate(QArrayData*) (qarraydata.h:459)
==49215==    by 0x42CC7A: QByteArray::~QByteArray() (in /home/tjmaciei/obj/qt/qt5/qtdeclarative/tests/auto/qml/qqmlproperty/tst_qqmlproperty)
==49215==    by 0x42AA8B: tst_qqmlproperty::floatToStringPrecision() (tst_qqmlproperty.cpp:2081)
==49215==    by 0x42BB37: tst_qqmlproperty::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (tst_qqmlproperty.moc:533)
==49215==    by 0x5E9B32D: QMetaMethod::invoke(QObject*, Qt::ConnectionType, QGenericReturnArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) const (qmetaobject.cpp:2237)
==49215==    by 0x40434FB: QMetaMethod::invoke(QObject*, Qt::ConnectionType, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) const (qmetaobject.h:123)
==49215==    by 0x403C39C: QTest::TestMethods::invokeTestOnData(int) const (qtestcase.cpp:838)
==49215==    by 0x403CE98: QTest::TestMethods::invokeTest(int, char const*, QTest::WatchDog*) const (qtestcase.cpp:1019)
==49215==    by 0x403DF45: QTest::TestMethods::invokeTests(QObject*) const (qtestcase.cpp:1321)
==49215==    by 0x403EA9F: QTest::qExec(QObject*, int, char**) (qtestcase.cpp:1733)
==49215==  Block was alloc'd at
==49215==    at 0x4C2D12F: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==49215==    by 0x5C3F4DE: allocateData(unsigned long, unsigned int) (qarraydata.cpp:107)
==49215==    by 0x5C3F6DE: QArrayData::allocate(QArrayData**, unsigned long, unsigned long, unsigned long, QFlags<QArrayData::ArrayOption>) (qarraydata.cpp:155)
==49215==    by 0x5C47BED: QTypedArrayData<char>::allocate(unsigned long, QFlags<QArrayData::ArrayOption>) (qarraydata.h:436)
==49215==    by 0x5C42123: QByteArray::QByteArray(int, Qt::Initialization) (qbytearray.cpp:1627)
==49215==    by 0x5D15F95: QString::toLatin1_helper(QChar const*, int) (qstring.cpp:4635)
==49215==    by 0x5D15F5F: QString::toLatin1_helper(QString const&) (qstring.cpp:4630)
==49215==    by 0x42D076: QString::toLatin1() const & (qstring.h:521)
==49215==    by 0x42AA69: tst_qqmlproperty::floatToStringPrecision() (tst_qqmlproperty.cpp:2081)
==49215==    by 0x42BB37: tst_qqmlproperty::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (tst_qqmlproperty.moc:533)
==49215==    by 0x5E9B32D: QMetaMethod::invoke(QObject*, Qt::ConnectionType, QGenericReturnArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) const (qmetaobject.cpp:2237)
==49215==    by 0x40434FB: QMetaMethod::invoke(QObject*, Qt::ConnectionType, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) const (qmetaobject.h:123)

Change-Id: I0031aa609e714ae983c3fffd146543f79048468f
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>

1 files changed, 3 insertions, 3 deletions

diff --git a/tests/auto/qml/qqmlproperty/tst_qqmlproperty.cpp b/tests/auto/qml/qqmlproperty/tst_qqmlproperty.cpp
index 5a8f2747a9..e140747881 100644
--- a/tests/auto/qml/qqmlproperty/tst_qqmlproperty.cpp
+++ b/tests/auto/qml/qqmlproperty/tst_qqmlproperty.cpp
@@ -2078,15 +2078,15 @@ void tst_qqmlproperty::floatToStringPrecision()
     QFETCH(QString, qtString);
     QFETCH(QString, jsString);
 
-    const char *name = propertyName.toLatin1().constData();
+    QByteArray name = propertyName.toLatin1();
     QCOMPARE(obj->property(name).toDouble(), number);
     QCOMPARE(obj->property(name).toString(), qtString);
 
-    const char *name1 = (propertyName + QLatin1Char('1')).toLatin1().constData();
+    QByteArray name1 = (propertyName + QLatin1Char('1')).toLatin1();
     QCOMPARE(obj->property(name1).toDouble(), number);
     QCOMPARE(obj->property(name1).toString(), qtString);
 
-    const char *name2 = (propertyName + QLatin1Char('2')).toLatin1().constData();
+    QByteArray name2 = (propertyName + QLatin1Char('2')).toLatin1();
     QCOMPARE(obj->property(name2).toDouble(), number);
     QCOMPARE(obj->property(name2).toString(), jsString);