aboutsummaryrefslogtreecommitdiffstats
path: root/examples/quick/canvas/LabeledSlider.qml
diff options
context:
space:
mode:
authorOliver Eftevaag <oliver.eftevaag@qt.io>2023-02-20 18:01:12 +0100
committerOliver Eftevaag <oliver.eftevaag@qt.io>2023-03-02 17:54:31 +0100
commit12e4871465a7552bb722733298a6c796b9fa4b30 (patch)
tree622f3f573ae576d6c169cb5eab6ffb45fb2c6fae /examples/quick/canvas/LabeledSlider.qml
parentd5d203cd6392b83adb43cb7b1c261f680b9a2658 (diff)
Canvas example: Improve usage of best practices
This commit updates the example in order to adopt as many best practices and follow our coding conventions from our official documentation. - qmllint will report no erros with this patch (As long as the shared module is imported). - strings are translated. - JS statements no longer end with semi-colon. - Removed unused properties and marked those that are only read as readonly Pick-to: 6.5 6.5.0 Change-Id: Ibe0d0750d48018b618a5cf8c3bcecb7e29488274 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Diffstat (limited to 'examples/quick/canvas/LabeledSlider.qml')
-rw-r--r--examples/quick/canvas/LabeledSlider.qml23
1 files changed, 11 insertions, 12 deletions
diff --git a/examples/quick/canvas/LabeledSlider.qml b/examples/quick/canvas/LabeledSlider.qml
index 5cab697b18..fa0ab98f78 100644
--- a/examples/quick/canvas/LabeledSlider.qml
+++ b/examples/quick/canvas/LabeledSlider.qml
@@ -7,32 +7,31 @@ import QtQuick.Controls
Item {
id: labeledSlider
property alias name: label.text
- implicitHeight: Math.max(label.implicitHeight, quickControlsSlider.implicitHeight)
property real min: 0.0
property real max: 1.0
- property real init: 0.0
- readonly property alias value: quickControlsSlider.value
+ property alias value: quickControlsSlider.value
+
+ implicitHeight: Math.max(label.implicitHeight, quickControlsSlider.implicitHeight)
Label {
id: label
anchors.left: parent.left
anchors.leftMargin: 10
- anchors.verticalCenter: parent.verticalCenter
- color: "#333"
+ anchors.verticalCenter: labeledSlider.verticalCenter
font: Qt.font({pointSize: 13})
}
Slider {
id: quickControlsSlider
- anchors.verticalCenter: parent.verticalCenter
- anchors.right: parent.right
- anchors.rightMargin: 10
- anchors.left: label.right
- anchors.leftMargin: 20
+ anchors {
+ verticalCenter: labeledSlider.verticalCenter
+ right: labeledSlider.right
+ rightMargin: 10
+ left: label.right
+ leftMargin: 10
+ }
from: labeledSlider.min
to: labeledSlider.max
width: labeledSlider.width - label.implicitWidth - (label.anchors.leftMargin + anchors.rightMargin + anchors.leftMargin)
-
- Component.onCompleted: ()=> value = labeledSlider.init;
}
}