diff options
| author | Lars Knoll <lars.knoll@qt.io> | 2018-07-01 11:33:04 +0200 |
|---|---|---|
| committer | Lars Knoll <lars.knoll@qt.io> | 2018-07-03 08:09:13 +0000 |
| commit | 6e79a00cad2f5dd09bdf40e594a65af58b370d9d (patch) | |
| tree | dc00a93fae797b24a53c0f858ae70904dc6f169c /src/qml/jit | |
| parent | dcbdb306f4442199384a71d532a3610a84d13fd5 (diff) | |
Get rid of the duplication for the GetLookup instructions
GetLookup and GetLookupA were doing exactly the same thing. Only keep
the version that expects the base object in the accumulator and
rename it to GetLookup.
Change-Id: Ia14256880cef23f7b70d8c7e6bb74aba371b8d9a
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Diffstat (limited to 'src/qml/jit')
| -rw-r--r-- | src/qml/jit/qv4baselinejit.cpp | 14 | ||||
| -rw-r--r-- | src/qml/jit/qv4baselinejit_p.h | 3 |
2 files changed, 2 insertions, 15 deletions
diff --git a/src/qml/jit/qv4baselinejit.cpp b/src/qml/jit/qv4baselinejit.cpp index b52350a729..1df7223936 100644 --- a/src/qml/jit/qv4baselinejit.cpp +++ b/src/qml/jit/qv4baselinejit.cpp @@ -265,19 +265,7 @@ void BaselineJIT::generate_LoadProperty(int name) as->checkException(); } -void BaselineJIT::generate_GetLookup(int index, int base) -{ - STORE_IP(); - as->prepareCallWithArgCount(4); - as->passRegAsArg(base, 3); - as->passInt32AsArg(index, 2); - as->passFunctionAsArg(1); - as->passEngineAsArg(0); - JIT_GENERATE_RUNTIME_CALL(Helpers::getLookup, Assembler::ResultInAccumulator); - as->checkException(); -} - -void BaselineJIT::generate_GetLookupA(int index) +void BaselineJIT::generate_GetLookup(int index) { STORE_IP(); STORE_ACC(); diff --git a/src/qml/jit/qv4baselinejit_p.h b/src/qml/jit/qv4baselinejit_p.h index 26da3d5da3..d953d86a06 100644 --- a/src/qml/jit/qv4baselinejit_p.h +++ b/src/qml/jit/qv4baselinejit_p.h @@ -101,8 +101,7 @@ public: void generate_LoadElement(int base) override; void generate_StoreElement(int base, int index) override; void generate_LoadProperty(int name) override; - void generate_GetLookup(int index, int base) override; - void generate_GetLookupA(int index) override; + void generate_GetLookup(int index) override; void generate_StoreProperty(int name, int base) override; void generate_SetLookup(int index, int base) override; void generate_StoreScopeObjectProperty(int base, |