Fix the RegExpCache to be GC safe

Change-Id: I6c20c2c5fcdaefa0743f7c1f50cf6dd8d8edc753
Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>

1 files changed, 11 insertions, 12 deletions

diff --git a/src/qml/jsruntime/qv4regexp.cpp b/src/qml/jsruntime/qv4regexp.cpp
index 715df2d666..31fee534ad 100644
--- a/src/qml/jsruntime/qv4regexp.cpp
+++ b/src/qml/jsruntime/qv4regexp.cpp
@@ -40,10 +40,10 @@ using namespace QV4;
 
 RegExpCache::~RegExpCache()
 {
-    for (RegExpCache::Iterator it = begin(), e = end();
-         it != e; ++it)
-        it.value()->cache = 0;
-    clear();
+    for (RegExpCache::Iterator it = begin(), e = end(); it != e; ++it) {
+        if (RegExp *re = it.value().as<RegExp>())
+            re->d()->cache = 0;
+    }
 }
 
 DEFINE_MANAGED_VTABLE(RegExp);
@@ -68,19 +68,18 @@ Heap::RegExp *RegExp::create(ExecutionEngine* engine, const QString& pattern, bo
     RegExpCacheKey key(pattern, ignoreCase, multiline);
 
     RegExpCache *cache = engine->regExpCache;
-    if (cache) {
-        if (Heap::RegExp *result = cache->value(key))
-            return result;
-    }
+    if (!cache)
+        cache = engine->regExpCache = new RegExpCache;
+
+    QV4::WeakValue &cachedValue = (*cache)[key];
+    if (QV4::RegExp *result = cachedValue.as<RegExp>())
+        return result->d();
 
     Scope scope(engine);
     Scoped<RegExp> result(scope, engine->memoryManager->alloc<RegExp>(engine, pattern, ignoreCase, multiline));
 
-    if (!cache)
-        cache = engine->regExpCache = new RegExpCache;
-
     result->d()->cache = cache;
-    cache->insert(key, result->d());
+    cachedValue.set(engine, result);
 
     return result->d();
 }