Fix array-like methods on V4 sequences

We need to properly convert value type lists on assignment and we need
to add the "length" property to the own properties. Furthermore, the V4
sequence methods were confused about integer type ranges. We teach
them about qsizetype, properly range check everything, and drop the
artificial limitation to INT_MAX.

Pick-to: 6.4
Task-number: QTBUG-82443
Change-Id: Ie5af1130c9e78e412c171e6fa26a28a6a7a5d498
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>

1 files changed, 7 insertions, 12 deletions

diff --git a/src/qml/jsruntime/qv4sequenceobject_p.h b/src/qml/jsruntime/qv4sequenceobject_p.h
index 51cdc2fc2c..256d324355 100644
--- a/src/qml/jsruntime/qv4sequenceobject_p.h
+++ b/src/qml/jsruntime/qv4sequenceobject_p.h
@@ -75,26 +75,21 @@ public:
     static QV4::ReturnedValue virtualGet(
             const QV4::Managed *that, PropertyKey id, const Value *receiver, bool *hasProperty);
     static bool virtualPut(Managed *that, PropertyKey id, const QV4::Value &value, Value *receiver);
-    static QV4::PropertyAttributes queryIndexed(const QV4::Managed *that, uint index);
     static bool virtualDeleteProperty(QV4::Managed *that, PropertyKey id);
     static bool virtualIsEqualTo(Managed *that, Managed *other);
     static QV4::OwnPropertyKeyIterator *virtualOwnPropertyKeys(const Object *m, Value *target);
 
     qsizetype size() const;
-    QVariant at(int index) const;
+    QVariant at(qsizetype index) const;
     void append(const QVariant &item);
-    void replace(int index, const QVariant &item);
-    void removeLast(int num);
+    void append(qsizetype num, const QVariant &item);
+    void replace(qsizetype index, const QVariant &item);
+    void removeLast(qsizetype num);
     QVariant toVariant() const;
 
-    //  ### Qt 7 use qsizetype instead.
-    QV4::ReturnedValue containerGetIndexed(uint index, bool *hasProperty) const;
-
-    //  ### Qt 7 use qsizetype instead.
-    bool containerPutIndexed(uint index, const QV4::Value &value);
-
-    QV4::PropertyAttributes containerQueryIndexed(uint index) const;
-    bool containerDeleteIndexedProperty(uint index);
+    QV4::ReturnedValue containerGetIndexed(qsizetype index, bool *hasProperty) const;
+    bool containerPutIndexed(qsizetype index, const QV4::Value &value);
+    bool containerDeleteIndexedProperty(qsizetype index);
     bool containerIsEqualTo(Managed *other);
     bool sort(const FunctionObject *f, const Value *, const Value *argv, int argc);
     void *getRawContainerPtr() const;