Clean up PropertyCache life cycle

We generally want to use QQmlRefPointer for it, rather than manually
calling addref() and release() all over the place. Also, we can
completely inline its ctor and drop an unused member.

Also, do not keep property caches of dynamic meta objects in type
registry. The dynamic metaobjects will change, and the outdated
property caches will eventually be retrieved.

Change-Id: I8042c85b32f3031b554f97a35c1545a3412d2acb
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>

1 files changed, 2 insertions, 2 deletions

diff --git a/src/qml/qml/qqmlmetaobject_p.h b/src/qml/qml/qqmlmetaobject_p.h
index be57ff3999..2998e2542f 100644
--- a/src/qml/qml/qqmlmetaobject_p.h
+++ b/src/qml/qml/qqmlmetaobject_p.h
@@ -75,7 +75,7 @@ public:
     inline QQmlMetaObject() = default;
     inline QQmlMetaObject(const QObject *);
     inline QQmlMetaObject(const QMetaObject *);
-    inline QQmlMetaObject(QQmlPropertyCache *);
+    inline QQmlMetaObject(const QQmlRefPointer<QQmlPropertyCache> &);
     inline QQmlMetaObject(const QQmlMetaObject &);
 
     inline QQmlMetaObject &operator=(const QQmlMetaObject &);
@@ -127,7 +127,7 @@ QQmlMetaObject::QQmlMetaObject(const QMetaObject *m)
 {
 }
 
-QQmlMetaObject::QQmlMetaObject(QQmlPropertyCache *m)
+QQmlMetaObject::QQmlMetaObject(const QQmlRefPointer<QQmlPropertyCache> &m)
 {
     if (m)
         _m = m->createMetaObject();