aboutsummaryrefslogtreecommitdiffstats
path: root/src/quick/items/qquickloader.cpp
diff options
context:
space:
mode:
authorWang Chuan <ouchuanm@outlook.com>2020-05-04 11:09:13 +0800
committerWang Chuan <ouchuanm@outlook.com>2020-05-05 15:22:14 +0800
commita135f3d6c3202b37eda0f1e94292f795f9e575ca (patch)
treec7a7960fe4da5e4740b5cac773078b720c46254d /src/quick/items/qquickloader.cpp
parentc1ae217a52ace4b955577bf0aaf1c4c8afb8b81b (diff)
QQuickLoader: prevent clearing initial properties after active = true
After commit b6d88c73, we implement the method [disposeInitialPropertyValues] and clear the cache of initial properties actually. Since we also call this method after source loaded, it will cause loss of initial properties after active = true. Fixes: QTBUG-83895 Change-Id: Iaa500fff14dcaad79a9e68dcbac9f65fa8720456 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Simon Hausmann <hausmann@gmail.com>
Diffstat (limited to 'src/quick/items/qquickloader.cpp')
-rw-r--r--src/quick/items/qquickloader.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/quick/items/qquickloader.cpp b/src/quick/items/qquickloader.cpp
index 43b70b23c2..40e0c3219a 100644
--- a/src/quick/items/qquickloader.cpp
+++ b/src/quick/items/qquickloader.cpp
@@ -711,7 +711,6 @@ void QQuickLoaderPrivate::incubatorStateChanged(QQmlIncubator::Status status)
emit q->progressChanged();
if (status == QQmlIncubator::Ready)
emit q->loaded();
- disposeInitialPropertyValues(); // cleanup
}
void QQuickLoaderPrivate::_q_sourceLoaded()