diff options
author | Simon Hausmann <simon.hausmann@qt.io> | 2020-01-10 12:50:20 +0100 |
---|---|---|
committer | Simon Hausmann <simon.hausmann@qt.io> | 2020-01-13 11:32:00 +0100 |
commit | 3ca659657ccaf0d850e661c9312e0f98e153c9ff (patch) | |
tree | d5f53673c8c5da8ee9d48c92469b0c0060987ce5 /src/quick/items/qquicktableview.cpp | |
parent | e8ceb548c5b2a61b63f813812f813c67932d59b4 (diff) |
Fix crash in tst_qquicktableview
Avoid a range-for over a list that's sometimes modified during the
iteration.
Change-Id: I4888ace4ebb86bfaa9f92d7e6272114c0af01421
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Diffstat (limited to 'src/quick/items/qquicktableview.cpp')
-rw-r--r-- | src/quick/items/qquicktableview.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/quick/items/qquicktableview.cpp b/src/quick/items/qquicktableview.cpp index 4018ce33a5..8c0512065a 100644 --- a/src/quick/items/qquicktableview.cpp +++ b/src/quick/items/qquicktableview.cpp @@ -2054,7 +2054,8 @@ bool QQuickTableViewPrivate::updateTableRecursive() if (!updateComplete) return false; - for (auto syncChild : qAsConst(syncChildren)) { + const auto children = syncChildren; + for (auto syncChild : children) { auto syncChild_d = syncChild->d_func(); syncChild_d->scheduledRebuildOptions |= rebuildOptions; |