aboutsummaryrefslogtreecommitdiffstats
path: root/tests/auto/qml/ecmascripttests/qjstest/test262runner.cpp
diff options
context:
space:
mode:
authorSimon Hausmann <simon.hausmann@qt.io>2018-06-18 15:41:22 +0200
committerSimon Hausmann <simon.hausmann@qt.io>2018-07-02 10:42:36 +0000
commite6d19ae5cf697087bbecce9d6f702afef7c29253 (patch)
tree2c259dc3526ae0d7b76fd2dd70ba46a79b50e236 /tests/auto/qml/ecmascripttests/qjstest/test262runner.cpp
parent090b0978f3546a10784992c3e4b1eb40427e0353 (diff)
Fix running the ES test suite
When we have one or more failures, make sure that the auto-test fails. This produces a few additional failures but oddly also "fixes" some tests that are marked as expected failure. Change-Id: I0bbbed463b326336ab9caa33f434520c90ed36de Reviewed-by: Lars Knoll <lars.knoll@qt.io>
Diffstat (limited to 'tests/auto/qml/ecmascripttests/qjstest/test262runner.cpp')
-rw-r--r--tests/auto/qml/ecmascripttests/qjstest/test262runner.cpp7
1 files changed, 4 insertions, 3 deletions
diff --git a/tests/auto/qml/ecmascripttests/qjstest/test262runner.cpp b/tests/auto/qml/ecmascripttests/qjstest/test262runner.cpp
index 2a14bdb463..bd945047c1 100644
--- a/tests/auto/qml/ecmascripttests/qjstest/test262runner.cpp
+++ b/tests/auto/qml/ecmascripttests/qjstest/test262runner.cpp
@@ -123,17 +123,17 @@ bool Test262Runner::run()
if (threadPool)
threadPool->waitForDone();
- report();
+ const bool testsOk = report();
if (flags & WriteTestExpectations)
writeTestExpectations();
else if (flags & UpdateTestExpectations)
updateTestExpectations();
- return true;
+ return testsOk;
}
-void Test262Runner::report()
+bool Test262Runner::report()
{
qDebug() << "Test execution summary:";
qDebug() << " Executed" << testCases.size() << "test cases.";
@@ -170,6 +170,7 @@ void Test262Runner::report()
for (const QString &f : qAsConst(unexpectedPasses))
qDebug() << " " << f;
}
+ return crashes.isEmpty() && unexpectedFailures.isEmpty() && unexpectedPasses.isEmpty();
}
bool Test262Runner::loadTests()