QtQml: Fix and test edge cases of QQmlFile's local file detection

URLs with two slashes after the colon are generally _not_ local as they
contain an authority. However, file URLs with two slashes are
interpreted as "special" paths by QUrl::toLocalFile(). Therefore, we
accept them.

URLs without slashes after the colon can be local files. They denote
relative paths or special android resources then.

Pick-to: 6.2 6.3
Fixes: QTBUG-102944
Change-Id: Iaab3d7501b631e88ee8c1d93f1de8149ba60a5c4
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>

5 files changed, 129 insertions, 0 deletions

diff --git a/tests/auto/qml/qqmlapplicationengine/CMakeLists.txt b/tests/auto/qml/qqmlapplicationengine/CMakeLists.txt
index d9fbf6517d..caf1e2edaa 100644
--- a/tests/auto/qml/qqmlapplicationengine/CMakeLists.txt
+++ b/tests/auto/qml/qqmlapplicationengine/CMakeLists.txt
@@ -55,3 +55,4 @@ qt_internal_extend_target(tst_qqmlapplicationengine CONDITION NOT ANDROID AND NO
         QT_QMLTEST_DATADIR=\\\"${CMAKE_CURRENT_SOURCE_DIR}/data\\\"
 )
 add_subdirectory(testapp)
+add_subdirectory(androidassets)
diff --git a/tests/auto/qml/qqmlapplicationengine/androidassets/CMakeLists.txt b/tests/auto/qml/qqmlapplicationengine/androidassets/CMakeLists.txt
new file mode 100644
index 0000000000..1c0d305311
--- /dev/null
+++ b/tests/auto/qml/qqmlapplicationengine/androidassets/CMakeLists.txt
@@ -0,0 +1,18 @@
+qt_internal_add_test(tst_androidassets
+    SOURCES
+        tst_androidassets.cpp
+    PUBLIC_LIBRARIES
+        Qt::Gui
+        Qt::Qml
+        Qt::Quick
+)
+
+# add qml/*.qml files as assets instead of resources
+
+file(
+    COPY qml/main.qml
+    DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/android-build/assets/qml/")
+
+file(
+    COPY qml/pages/MainPage.qml
+    DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/android-build/assets/qml/pages/")
diff --git a/tests/auto/qml/qqmlapplicationengine/androidassets/qml/main.qml b/tests/auto/qml/qqmlapplicationengine/androidassets/qml/main.qml
new file mode 100644
index 0000000000..6901572b00
--- /dev/null
+++ b/tests/auto/qml/qqmlapplicationengine/androidassets/qml/main.qml
@@ -0,0 +1,13 @@
+import QtQuick
+
+// relative import: has to work when loading from android assets by path or by URL
+import "pages"
+
+Window {
+  width: 640
+  height: 480
+  visible: true
+  title: qsTr("Hello World")
+
+  MainPage { }
+}
diff --git a/tests/auto/qml/qqmlapplicationengine/androidassets/qml/pages/MainPage.qml b/tests/auto/qml/qqmlapplicationengine/androidassets/qml/pages/MainPage.qml
new file mode 100644
index 0000000000..c9549a928a
--- /dev/null
+++ b/tests/auto/qml/qqmlapplicationengine/androidassets/qml/pages/MainPage.qml
@@ -0,0 +1,11 @@
+import QtQuick
+
+Rectangle {
+  anchors.fill: parent
+  color: "#ddd"
+
+  Text {
+    anchors.centerIn: parent
+    text: "Qt 6"
+  }
+}
diff --git a/tests/auto/qml/qqmlapplicationengine/androidassets/tst_androidassets.cpp b/tests/auto/qml/qqmlapplicationengine/androidassets/tst_androidassets.cpp
new file mode 100644
index 0000000000..1926cf4fab
--- /dev/null
+++ b/tests/auto/qml/qqmlapplicationengine/androidassets/tst_androidassets.cpp
@@ -0,0 +1,86 @@
+/****************************************************************************
+**
+** Copyright (C) 2022 The Qt Company Ltd.
+** Contact: https://www.qt.io/licensing/
+**
+** This file is part of the test suite of the Qt Toolkit.
+**
+** $QT_BEGIN_LICENSE:GPL-EXCEPT$
+** Commercial License Usage
+** Licensees holding valid commercial Qt licenses may use this file in
+** accordance with the commercial license agreement provided with the
+** Software or, alternatively, in accordance with the terms contained in
+** a written agreement between you and The Qt Company. For licensing terms
+** and conditions see https://www.qt.io/terms-conditions. For further
+** information use the contact form at https://www.qt.io/contact-us.
+**
+** GNU General Public License Usage
+** Alternatively, this file may be used under the terms of the GNU
+** General Public License version 3 as published by the Free Software
+** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
+** included in the packaging of this file. Please review the following
+** information to ensure the GNU General Public License requirements will
+** be met: https://www.gnu.org/licenses/gpl-3.0.html.
+**
+** $QT_END_LICENSE$
+**
+****************************************************************************/
+
+#include <QtQml/qqmlapplicationengine.h>
+#include <QtTest/qsignalspy.h>
+#include <QtTest/qtest.h>
+
+class tst_AndroidAssets : public QObject
+{
+    Q_OBJECT
+private Q_SLOTS:
+    void loadsFromAssetsPath();
+    void loadsFromAssetsUrl();
+
+private:
+
+    static QString pathPrefix()
+    {
+#ifdef Q_OS_ANDROID
+        return QStringLiteral("assets:");
+#else
+        // Even when not running on android we can check that the copying to build dir worked.
+        return QCoreApplication::applicationDirPath() + QStringLiteral("/android-build/assets");
+#endif
+    }
+
+    static QString urlPrefix() {
+#ifdef Q_OS_ANDROID
+        return pathPrefix();
+#else
+        return QStringLiteral("file:") + pathPrefix();
+#endif
+    }
+};
+
+
+void tst_AndroidAssets::loadsFromAssetsPath()
+{
+    QQmlApplicationEngine engine;
+    QSignalSpy failureSpy(&engine, &QQmlApplicationEngine::objectCreationFailed);
+
+    // load QML file from assets, by path:
+    engine.load(pathPrefix() + QStringLiteral("/qml/main.qml"));
+    QTRY_VERIFY(engine.rootObjects().length() == 1);
+    QVERIFY(failureSpy.isEmpty());
+}
+
+void tst_AndroidAssets::loadsFromAssetsUrl()
+{
+    QQmlApplicationEngine engine;
+    QSignalSpy failureSpy(&engine, &QQmlApplicationEngine::objectCreationFailed);
+
+    // load QML file from assets, by URL:
+    engine.load(QUrl(urlPrefix() + QStringLiteral("/qml/main.qml")));
+    QTRY_VERIFY(engine.rootObjects().length() == 1);
+    QVERIFY(failureSpy.isEmpty());
+}
+
+QTEST_MAIN(tst_AndroidAssets)
+
+#include "tst_androidassets.moc"