diff options
author | Mitch Curtis <mitch.curtis@qt.io> | 2021-08-06 12:27:35 +0200 |
---|---|---|
committer | Mitch Curtis <mitch.curtis@qt.io> | 2021-09-13 21:17:04 +0200 |
commit | e310dadef779b28845b41fb091634cd001cda9de (patch) | |
tree | 610be234e82cc53752f58521ae3beba4693ff78f /tests/auto/qml/qqmldirparser | |
parent | de0c1c8a4c834dcc080d1b374186a82cd86921ca (diff) |
Consolidate test helpers into private libraries
Previously each test would include and build sources from the shared
folder. Now we make those sources a library, build it once, then have
each test link to it instead.
We also take the opportunity to move some helpers that qtquickcontrols2
had added into the quicktestutils library where it makes sense, and
for the helpers that don't make sense to be there, move them into
quickcontrolstestutils.
We add the libraries to src/ so that they are internal modules built as
part of Qt, rather than tests. That way we can use them in a standalone
test outside of qtdeclarative.
Task-number: QTBUG-95621
Pick-to: 6.2
Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'tests/auto/qml/qqmldirparser')
-rw-r--r-- | tests/auto/qml/qqmldirparser/CMakeLists.txt | 4 | ||||
-rw-r--r-- | tests/auto/qml/qqmldirparser/tst_qqmldirparser.cpp | 4 |
2 files changed, 3 insertions, 5 deletions
diff --git a/tests/auto/qml/qqmldirparser/CMakeLists.txt b/tests/auto/qml/qqmldirparser/CMakeLists.txt index 255cc75c6a..f8e3e36ef7 100644 --- a/tests/auto/qml/qqmldirparser/CMakeLists.txt +++ b/tests/auto/qml/qqmldirparser/CMakeLists.txt @@ -12,14 +12,12 @@ list(APPEND test_data ${test_data_glob}) qt_internal_add_test(tst_qqmldirparser SOURCES - ../../shared/util.cpp ../../shared/util.h tst_qqmldirparser.cpp - INCLUDE_DIRECTORIES - ../../shared PUBLIC_LIBRARIES Qt::Gui Qt::Qml Qt::QmlPrivate + Qt::QuickTestUtilsPrivate TESTDATA ${test_data} ) diff --git a/tests/auto/qml/qqmldirparser/tst_qqmldirparser.cpp b/tests/auto/qml/qqmldirparser/tst_qqmldirparser.cpp index 8f0c58653b..64658e8546 100644 --- a/tests/auto/qml/qqmldirparser/tst_qqmldirparser.cpp +++ b/tests/auto/qml/qqmldirparser/tst_qqmldirparser.cpp @@ -26,8 +26,6 @@ ** ****************************************************************************/ -#include "../../shared/util.h" - #include <qtest.h> #include <QObject> #include <QQmlEngine> @@ -35,6 +33,7 @@ #include <private/qqmljsdiagnosticmessage_p.h> #include <private/qqmldirparser_p.h> #include <QDebug> +#include <QtQuickTestUtils/private/qmlutils_p.h> #include <algorithm> @@ -52,6 +51,7 @@ private slots: }; tst_qqmldirparser::tst_qqmldirparser() + : QQmlDataTest(QT_QMLTEST_DATADIR) { } |