diff options
| author | Ulf Hermann <ulf.hermann@qt.io> | 2023-05-30 15:23:38 +0200 |
|---|---|---|
| committer | Ulf Hermann <ulf.hermann@qt.io> | 2023-06-05 13:27:53 +0000 |
| commit | 8679fa2478414162a9f3030c8997e7404775983f (patch) | |
| tree | 455d9c4dc9ebcce95e8eb4c895f9642fc8427390 /tests/auto/qml/qqmlecmascript | |
| parent | 6d1317e11a8a85f23190df02ae0c69f9e4420b0e (diff) | |
Disable flaky test in tst_qqmlecmascript
Since structured value types can be created from any object (even if
none of the properties match), this test doesn't test anything anymore.
The explanation is still valuable, so let's keep the code commented.
Pick-to: 6.5 6.6
Change-Id: I890204811a522f025fb114f51e57c1dd4a951a57
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'tests/auto/qml/qqmlecmascript')
| -rw-r--r-- | tests/auto/qml/qqmlecmascript/tst_qqmlecmascript.cpp | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/tests/auto/qml/qqmlecmascript/tst_qqmlecmascript.cpp b/tests/auto/qml/qqmlecmascript/tst_qqmlecmascript.cpp index 98f81c4648..2684157840 100644 --- a/tests/auto/qml/qqmlecmascript/tst_qqmlecmascript.cpp +++ b/tests/auto/qml/qqmlecmascript/tst_qqmlecmascript.cpp @@ -3129,11 +3129,14 @@ void tst_qqmlecmascript::callQtInvokables() QCOMPARE(o->invoked(), -1); QCOMPARE(o->actuals().size(), 0); - o->reset(); - QVERIFY(EVALUATE_ERROR("object.method_QPointF(object)")); - QCOMPARE(o->error(), false); - QCOMPARE(o->invoked(), -1); - QCOMPARE(o->actuals().size(), 0); + // This fails if the QtQml module is loaded but works if it's not. + // If QtQml is loaded, QPointF is a structured value type that can be created from any object. + // + // o->reset(); + // QVERIFY(EVALUATE_ERROR("object.method_QPointF(object)")); + // QCOMPARE(o->error(), false); + // QCOMPARE(o->invoked(), -1); + // QCOMPARE(o->actuals().size(), 0); o->reset(); QVERIFY(EVALUATE_VALUE("object.method_QPointF(object.method_get_QPointF())", QV4::Primitive::undefinedValue())); |