diff options
| author | Edward Welbourne <edward.welbourne@qt.io> | 2023-04-20 14:37:09 +0200 |
|---|---|---|
| committer | Edward Welbourne <edward.welbourne@qt.io> | 2023-04-25 16:53:00 +0200 |
| commit | b4e0f9efa210b97d38a67447c55ab54d42913fe4 (patch) | |
| tree | 85264c392bac9083924189f49f319c0e024a510c /tests/auto/qml/qqmlxmlhttprequest | |
| parent | 42955653cb474c80a81ab1d5a92cf9e2e56a10bc (diff) | |
Remove spurious && true from two boolean conditions in XHR test QML
The properties modified by this condition are booleans, that have been
set, so there is no need to && true them to ensure they are boolean.
Change-Id: I94f166c91549a5c212de5f694901896657cd04e0
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Diffstat (limited to 'tests/auto/qml/qqmlxmlhttprequest')
| -rw-r--r-- | tests/auto/qml/qqmlxmlhttprequest/data/getAllResponseHeaders.qml | 2 | ||||
| -rw-r--r-- | tests/auto/qml/qqmlxmlhttprequest/data/getResponseHeader.qml | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/tests/auto/qml/qqmlxmlhttprequest/data/getAllResponseHeaders.qml b/tests/auto/qml/qqmlxmlhttprequest/data/getAllResponseHeaders.qml index 9379e1c105..9d64aa72bb 100644 --- a/tests/auto/qml/qqmlxmlhttprequest/data/getAllResponseHeaders.qml +++ b/tests/auto/qml/qqmlxmlhttprequest/data/getAllResponseHeaders.qml @@ -56,7 +56,7 @@ QtObject { headersReceivedHeader = (x.getAllResponseHeaders() == headers); } else if (x.readyState == XMLHttpRequest.DONE) { - doneState = headersReceivedState && true; + doneState = headersReceivedState; doneHeader = (x.getAllResponseHeaders() == headers); dataOK = (x.responseText == "QML Rocks!\n"); diff --git a/tests/auto/qml/qqmlxmlhttprequest/data/getResponseHeader.qml b/tests/auto/qml/qqmlxmlhttprequest/data/getResponseHeader.qml index b740a27785..0e594af650 100644 --- a/tests/auto/qml/qqmlxmlhttprequest/data/getResponseHeader.qml +++ b/tests/auto/qml/qqmlxmlhttprequest/data/getResponseHeader.qml @@ -62,7 +62,7 @@ QtObject { (x.getResponseHeader("Set-Cookie") == "" && x.getResponseHeader("Set-Cookie2") == ""); } else if (x.readyState == XMLHttpRequest.DONE) { - doneState = headersReceivedState && true; + doneState = headersReceivedState; doneNullHeader = (x.getResponseHeader("Nonexistant-header") == ""); doneValidHeader = (x.getResponseHeader("Test-HEAder") == "TestValue"); |