diff options
| author | Mitch Curtis <mitch.curtis@qt.io> | 2022-04-12 10:09:13 +0800 |
|---|---|---|
| committer | Mitch Curtis <mitch.curtis@qt.io> | 2022-04-12 20:03:18 +0800 |
| commit | de862d197b8ecd2cdd5e3ee4ca0d40fcd987b5d5 (patch) | |
| tree | d4d26d406a866a1010a6946f65f8a99908d16cc2 /tests/auto/quickdialogs | |
| parent | 0599ed62729e1bdebfc7028197f12bd3d6e6a298 (diff) | |
Fix flaky tst_QQuickFolderDialogImpl::goUp test
Don't listen to folderDialogListView's currentIndexChanged signal while
setting its currentIndex, because the file associated with the delegate
is not correct at that stage.
Fixes: QTBUG-102415
Change-Id: I309c993742d29d23290af297c2a91c9c31d23a0e
Pick-to: 6.2 6.3
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Diffstat (limited to 'tests/auto/quickdialogs')
| -rw-r--r-- | tests/auto/quickdialogs/qquickfolderdialogimpl/BLACKLIST | 3 | ||||
| -rw-r--r-- | tests/auto/quickdialogs/qquickfolderdialogimpl/tst_qquickfolderdialogimpl.cpp | 2 |
2 files changed, 1 insertions, 4 deletions
diff --git a/tests/auto/quickdialogs/qquickfolderdialogimpl/BLACKLIST b/tests/auto/quickdialogs/qquickfolderdialogimpl/BLACKLIST index 3260348231..c03383b79f 100644 --- a/tests/auto/quickdialogs/qquickfolderdialogimpl/BLACKLIST +++ b/tests/auto/quickdialogs/qquickfolderdialogimpl/BLACKLIST @@ -1,6 +1,3 @@ # QTBUG-92094 [tabFocusNavigation] * - -[goUp] -* # QTBUG-102415 diff --git a/tests/auto/quickdialogs/qquickfolderdialogimpl/tst_qquickfolderdialogimpl.cpp b/tests/auto/quickdialogs/qquickfolderdialogimpl/tst_qquickfolderdialogimpl.cpp index e73e3166ed..eadb355e82 100644 --- a/tests/auto/quickdialogs/qquickfolderdialogimpl/tst_qquickfolderdialogimpl.cpp +++ b/tests/auto/quickdialogs/qquickfolderdialogimpl/tst_qquickfolderdialogimpl.cpp @@ -507,7 +507,7 @@ void tst_QQuickFolderDialogImpl::goUp() QTRY_VERIFY(findViewDelegateItem(folderDialogListView, 0, subDirDelegate)); QCOMPARE(subDirDelegate->isHighlighted(), true); - // Go up a directory via the keyboard shortcut next to the breadcrumb bar. + // Go up a directory via the keyboard shortcut. const auto goUpKeySequence = QKeySequence(Qt::ALT | Qt::Key_Up); QTest::keySequence(dialogHelper.window(), goUpKeySequence); QDir tempParentDir(tempDir.path()); |