diff options
| author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2022-05-10 19:01:45 +0200 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2022-05-13 12:21:47 +0200 |
| commit | 6a43bc591edd2106c719378ba4e14d7aa52ba805 (patch) | |
| tree | 46e637795163fbed2269af7b3ac25f1be6e918de /tests | |
| parent | 7a5bbc23150fe73f86e9eb81d252cb8ebc673784 (diff) | |
Fix use after free in test
Listener will get an event on QQuickItem destruction.
Change-Id: I556d2df27f5da7206c67f13eca9d2117b52bc489
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/auto/quick/qquickstates/tst_qquickstates.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/auto/quick/qquickstates/tst_qquickstates.cpp b/tests/auto/quick/qquickstates/tst_qquickstates.cpp index d6814bd057..75a0837574 100644 --- a/tests/auto/quick/qquickstates/tst_qquickstates.cpp +++ b/tests/auto/quick/qquickstates/tst_qquickstates.cpp @@ -1841,6 +1841,7 @@ void tst_qquickstates::parentChangeInvolvingBindings() { QQmlEngine engine; QQmlComponent c(&engine, testFileUrl("parentChangeInvolvingBindings.qml")); + Listener listener; QScopedPointer<QQuickItem> root { qobject_cast<QQuickItem *>(c.create()) }; QVERIFY2(root, qPrintable(c.errorString())); @@ -1848,7 +1849,6 @@ void tst_qquickstates::parentChangeInvolvingBindings() QVERIFY(child); QQuickItem *childItem = qobject_cast<QQuickItem *>(child); QVERIFY(childItem); - Listener listener; QQuickItemPrivate::get(childItem)->addItemChangeListener(&listener, QQuickItemPrivate::Geometry); |